Skip to content

Fix components template not handling Action::Error - #136

Merged
orhun merged 1 commit into
ratatui:mainfrom
Serophots:main
Aug 14, 2026
Merged

orhun merged 1 commit into
ratatui:mainfrom
Serophots:main

Conversation

@Serophots

Copy link
Copy Markdown
Contributor

Fixes #135

Action::Error is used

fn render(&mut self, tui: &mut Tui) -> color_eyre::Result<()> {
tui.draw(|frame| {
for component in self.components.iter_mut() {
if let Err(err) = component.draw(frame, frame.area()) {
let _ = self
.action_tx
.send(Action::Error(format!("Failed to draw: {:?}", err)));
}
}
})?;
Ok(())
}

but never handled. This handles it simply with tracing::error!

@orhun orhun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@orhun
orhun merged commit 6f8a6fb into ratatui:main Aug 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

component template does not handle Action::Error anywhere

2 participants