Add FXMacroData return helpers - #532
Open
roberttidball wants to merge 2 commits into
Open
Conversation
roberttidball
marked this pull request as ready for review
August 26, 2026 02:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This keeps the integration aligned with QuantStats' return-series model. The two helpers load daily FX reference prices and convert them into a pandas return series; the update adds canonical URL handling, pagination, input validation, duplicate removal, and safe network/JSON errors.
Scope
FX history normally requires
FXMACRODATA_API_KEYorFXMD_API_KEY; raised errors do not include the request URL or key.Validation
python -m pytest tests/test_utils.py -q— 20 passedgit diff --checkI own FXMacroData and am contributing these helpers directly.