Skip to content

fix: touch each page in hard Chunk::preload walk #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-c-m wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: touch each page in hard Chunk::preload walk #838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/data/chunk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ Chunk::preload(uint32_t position, uint32_t length, bool useAdvise) {

} else {
for (char* first = static_cast<char*>(data.first), *last = static_cast<char*>(data.first) + data.second; first < last; first += 4096)
[[maybe_unused]] volatile char touchChunk = *static_cast<char*>(data.first);
[[maybe_unused]] volatile char touchChunk = *first;

// Make sure we touch the last page in the range.
[[maybe_unused]] volatile char ouchChunk = *(static_cast<char*>(data.first) + data.second - 1);
Expand Down
Loading