Fix tracker announce stalls with active scrapes#837
Open
szab100 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #836
rTorrent stops announcing to HTTP trackers while seeding, causing the tracker to eventually mark the torrent as stopped. Experienced through Socks5 proxy (socks5h://) via VPN.
Changes:
src/net/curl_stack.cc/h: Add ensure_timeout_scheduled() to guarantee the multi-socket timeout task is armed while any transfer is active, and call it from start_get(), receive_timeout(), and after socket eventsBackwards compatibility:
No behavior change for healthy trackers or connections. Stalled HTTP requests through proxy/VPN now time out and retry on schedule, and announces are no longer dropped because of an active scrape.
Announcements work perfectly with the fix.