feat(rewrite): add Phase 3 task domain - #396
Conversation
|
Important Review skippedToo many files! This PR contains 138 files, which is 38 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (34)
📒 Files selected for processing (138)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 254c27a13b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 703ba464e6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Summary
/tasksbrowser route using the shared accessible UI system, Headless UI, TanStack Form/Query,@dnd-kit/react, Lucide icons, and reusable Markdown/search/select/textarea/link primitives.@dnd-kit/coreand@dnd-kit/sortabledependencies; the current React package owns drag-and-drop behavior.Behavior and regression coverage
IMMEDIATEtransaction with optimistic versions, validated persisted rows, atomic audit/realtime records, and no callback replay after transaction entry.Verification
bun install --frozen-lockfilebun run check:boundariesbun run lintbun run typecheckbun run format:checkbun run test— 1,413 passed, 0 failedbun run test:coverage— 91.81% (33,234 / 36,199 lines; threshold 85%)bun run build:browserandbun run build:processesbun run docs:checkbun run db:checkgit diff --checkRisk checklist
.envfiles, database dumps, or runtime state committedDeployment / operations
Notes for reviewers
Please focus on optimistic transaction boundaries, cursor stability, capability separation, realtime invalidation, notification redaction/lease settlement, and browser mutation/cache behavior.