docs: remove stale alloy-ethers-typecast references from ARCHITECTURE.md#2798
docs: remove stale alloy-ethers-typecast references from ARCHITECTURE.md#2798thedavidmeister wants to merge 2 commits into
Conversation
The alloy-ethers-typecast dependency is no longer declared by any crate; describe the current dependency set (plain alloy plus raindex_bindings::provider::mk_read_provider) instead. Closes #2797 Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughUpdated architecture documentation to remove stale ChangesArchitecture documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🤖 ai:producer
|
|
🤖 ai:vetter |
|
🤖 ai:vetter |
|
🤖 ai:producer |
Closes #2797
Summary
alloy-ethers-typecastis no longer a dependency of any crate (absent from everyCargo.toml,Cargo.lock, and all Rust sources), but two ARCHITECTURE.md lines still listed it. This updates both to describe the current dependency set:crates/quote/ARCHITECTURE.md: removed thealloy-ethers-typecast::ReadableClientbullet ("convenience for fetching block number across multiple HTTP RPCs" — the quote crate no longer fetches block numbers; callers pass an optional block number mapped to aBlockId). Its still-true multi-RPC fact moved into the existingraindex_bindingsbullet:mk_read_providerbuilds an alloy provider with fallback across multiple HTTP RPCs (FallbackLayerincrates/bindings/src/provider.rs).crates/common/ARCHITECTURE.md: "alloy&alloy_ethers_typecast— EVM primitives, providers, signers (Ledger), and Read/Write contract helpers" is now "alloy— EVM primitives, providers, signers (Ledger), and transaction building/sending" (Ledger viaalloy::signers::ledger::LedgerSignerincrates/common/src/transaction.rs; sending viaProvider::send_transactionincrates/common/src/write_tx.rs).QA
crates/quote/Cargo.toml,crates/common/Cargo.toml,Cargo.lock,crates/bindings/src/provider.rs(mk_read_provider+FallbackLayer),crates/quote/src/rpc.rs(caller-suppliedblock_number→BlockId; no block-number fetching),crates/common/src/transaction.rs(LedgerSigner,ProviderBuilder,TransactionRequest),crates/common/src/write_tx.rs(send_transaction)alloy_ethers_typecastdoc lines incrates/common/ARCHITECTURE.mdandcrates/quote/ARCHITECTURE.md; covered both, and a repo-wide grep confirms no other typecast references remain in docs or code🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Summary by CodeRabbit