Remove ruby2_keyword usage - #559
Open
Earlopain wants to merge 1 commit into
Open
Conversation
Also a bit easier to understand.
Member
|
Not too sure how I feel about this. This path is quite tricky to get right across 2.x and 3.x, so IMO If we were to drop 2.x then yes maybe, but I'm quite conservative on dropping old version support. |
Contributor
Author
|
Ah, my bad. I thought it was 3.0 already. Wanted to demonstrate for https://bugs.ruby-lang.org/issues/22205. Should have choosen something different 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also a bit easier to understand.