Skip to content

feat: liquid template with custom naming - #30

Draft
al3mart wants to merge 4 commits into
mainfrom
al3mart/feat-liquid-template
Draft

feat: liquid template with custom naming#30
al3mart wants to merge 4 commits into
mainfrom
al3mart/feat-liquid-template

Conversation

@al3mart

@al3mart al3mart commented Jun 26, 2024

Copy link
Copy Markdown
Member

This PR adapts base-parachain so it becomes a liquid template that can be used by tooling like pop-cli to bootstrap user projects.

  • User given name will be applied to the node, runtime, resulting binary and a few configurations in the respective Cargo files and network.toml.

Downsides:

  • This change makes base-parachain move away from being a rust project, cargo will error out as the syntax used for the template won't make it "cargo compliant".
    ( For instance, cargo fmt won't be able to run, and so this PR won't comply with the current CI, modifying the CI itself could be part of this PR if we all agree this is a good way forward )
  • Maintenance of this template, like upgrading it to new polkadot-sdk versions, might be a tad more painful because of the above.

Note:

  • With the sight set on omni-node advancements, we might/should get rid of everything node from this template. Making the maintenance not that big of a problem. And so, making it wort it to advance in this direction and evolve the template.
  • I had to move the macro construct_async_run outside of the node/src/command.rs file so that the template could be parsed properly. Now it lives in node/src/utils.rs.

@Daanvdplas

Copy link
Copy Markdown
Collaborator

What is the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants