Repository navigation
Read qaris from json file - #4043
Merged
Merged
Conversation
Instead of maintaining the qari list in code, this maintains it as a json file instead. This makes it easier to consider pushing this responsibility to the backend in the future in sha' Allah. It also helps lessen the code delta between the play store version and open source versions for #755.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of maintaining the qari list in code, this maintains it as a
json file instead. This makes it easier to consider pushing this
responsibility to the backend in the future in sha' Allah. It also helps
lessen the code delta between the play store version and open source
versions for #755.