Skip to content

fix(ui): keep empty-state text clear of the side safe areas - #1321

Open
mohamede1945 wants to merge 1 commit into
mainfrom
afifi/data-unavailable-side-safe-areas
Open

mohamede1945 wants to merge 1 commit into
mainfrom
afifi/data-unavailable-side-safe-areas

Conversation

@mohamede1945

Copy link
Copy Markdown
Collaborator

DataUnavailableView ignored every safe area, so its text was centered on the whole screen, including whatever sits on the sides. The background still fills the screen, but the content now respects the leading and trailing safe areas. The vertical layout is unchanged.

  • iPhone Duo: on the folded screen the status bar and tab bar sit in a column on one side, so the empty-state text sat off-center toward them. It's now centered in the space beside the column.
  • Other iPhones in landscape: the text keeps clear of the notch or Dynamic Island. Those insets are symmetric, so it stays centered and just wraps a little narrower.

Split out of #1280; authored by @iamraafay.

Screenshots

Before After
No results before No results after

Search with no results on the iPhone Duo simulator, folded.

Testing

  • make format-lint and make build-no-sync.
  • Checked on the iPhone Duo (folded) and iPhone 18 Pro (landscape) simulators, iOS 27.2.

🤖 Generated with Claude Code

DataUnavailableView ignored every safe area, so its content could sit under
whatever occupies the screen's sides. The background still fills the whole
screen, but the content now respects the leading and trailing safe areas.

This changes every iPhone, not only iPhone Duo: in iPhone landscape the
empty-state text moves clear of the notch or Dynamic Island, and on iPhone
Duo's outer display it stays clear of the vertical bar. The vertical layout
is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants