Repository navigation
fix(ui): keep empty-state text clear of the side safe areas - #1321
Open
mohamede1945 wants to merge 1 commit into
Open
mohamede1945 wants to merge 1 commit into
mohamede1945 wants to merge 1 commit into
Conversation
DataUnavailableView ignored every safe area, so its content could sit under whatever occupies the screen's sides. The background still fills the whole screen, but the content now respects the leading and trailing safe areas. This changes every iPhone, not only iPhone Duo: in iPhone landscape the empty-state text moves clear of the notch or Dynamic Island, and on iPhone Duo's outer display it stays clear of the vertical bar. The vertical layout is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataUnavailableViewignored every safe area, so its text was centered on the whole screen, including whatever sits on the sides. The background still fills the screen, but the content now respects the leading and trailing safe areas. The vertical layout is unchanged.Split out of #1280; authored by @iamraafay.
Screenshots
Search with no results on the iPhone Duo simulator, folded.
Testing
make format-lintandmake build-no-sync.🤖 Generated with Claude Code