Repository navigation
fix(ui): keep iPhone Duo's bar items visible and named - #1319
Open
mohamede1945 wants to merge 4 commits into
Open
mohamede1945 wants to merge 4 commits into
mohamede1945 wants to merge 4 commits into
Conversation
When a bar runs out of room, like iPhone Duo's vertical bar in folded landscape, the system moves items into a "•••" menu. Done went there untinted, and icon-only items such as Add, Share, Reverse order, and Choose Mushaf were listed as icons without a title. Done now has high visibility priority, so it stays in the bar. Icon-only items carry a titled menu entry that follows their enabled state and image, so the menu reads "Add Collection" or "Choose Mushaf", and Next and Previous turn off there too at the ends of the Quran. The bar still shows only the icons, and priority only matters once the bar runs out of room, so iPhone and iPad look the same. Notes' Share uses the new NavigationBarButton.share and keeps its tint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the tab bar and bar items share iPhone Duo's vertical bar, the system compresses the items first, so in folded landscape Done could still land in the overflow menu. Editing doesn't switch tabs, so while a list is in Edit mode its navigation item prefers bar items, and the tab bar compresses to the current tab instead. Without a vertical bar the setting has no effect, so iPhone and iPad don't change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Audio Options pushes the reciter list as a view controller inside SwiftUI, which laid it out inside the safe area. The list never saw the home indicator or iPhone Duo's vertical bar column, so a white band showed below it, and beside it on iPhone Duo. The pushed list now ignores the side and bottom safe area and reads it itself, like the reciter list from Settings, so its grouped background reaches the sheet's edges while its rows stay inset. The top is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On iPhone Duo the ayah notes sheet reserved an empty column for the vertical bar, so its content sat off-center with a wide right margin. The sheet's only bar item, Edit, is text, which the vertical bar doesn't show, and the medium detent has no status bar to share the column with. The sheet now presents through a navigation controller that opts out of the vertical bar, so it keeps a horizontal bar and centered content. Without a vertical bar, like on iPhone and iPad, the opt-out changes nothing. The sheet only dismisses, so it now has a leading Close, like the translated verse sheet, on every device. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iPhone Duo, iOS can move an app's tab bar and navigation bar items into a vertical bar: a column on one side of the screen that also holds the status bar. On the folded screen in landscape that column has room for about one item next to the tab bar, so the rest go into a system overflow menu (•••). This PR keeps the important items visible and makes the overflow menu readable.
NavigationBarButton.donegets a high visibility priority (iOS 27), and lists in edit mode let the tab bar shrink before their bar items do (iOS 27.1). Before, Bookmarks and Notes in edit mode hid Done in the overflow menu, without its tint.iPhone and iPad bars are unchanged apart from the last two items: the priority and compression settings only matter when items don't fit.
Stack: #1318 → this PR → #1280.
Screenshots
Testing
make format-lint,make build-no-syncandmake build-sync.NoorUITests,UIxTests,NotesFeatureTests,BookmarksFeatureTestsandAdvancedAudioOptionsFeatureTestspass. New cases cover Done's priority, the overflow entry following the item's state, image and action, the tab bar compression while editing, and the notes sheet's opt-out.🤖 Generated with Claude Code