Skip to content

fix(ui): keep iPhone Duo's bar items visible and named - #1319

Open
mohamede1945 wants to merge 4 commits into
afifi/ci-xcode-27-2from
afifi/duo-screens-pr
Open

mohamede1945 wants to merge 4 commits into
afifi/ci-xcode-27-2from
afifi/duo-screens-pr

Conversation

@mohamede1945

@mohamede1945 mohamede1945 commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

On iPhone Duo, iOS can move an app's tab bar and navigation bar items into a vertical bar: a column on one side of the screen that also holds the status bar. On the folded screen in landscape that column has room for about one item next to the tab bar, so the rest go into a system overflow menu (•••). This PR keeps the important items visible and makes the overflow menu readable.

  • Done stays in the bar. NavigationBarButton.done gets a high visibility priority (iOS 27), and lists in edit mode let the tab bar shrink before their bar items do (iOS 27.1). Before, Bookmarks and Notes in edit mode hid Done in the overflow menu, without its tint.
  • Overflow rows have names. Icon-only bar items (add, share, reverse order, Choose Mushaf, next and previous verse) now carry a titled menu entry for the overflow menu, which follows the item's enabled state and image. They also get VoiceOver labels. The bars themselves look the same.
  • Reciter list in Audio Options. Its background now reaches the sheet's edges. This also removes the white band at the bottom of that sheet on every iPhone.
  • Ayah notes sheet. It opts out of the vertical bar, which reserved an empty column and pushed the notes off-center. It also gets a leading Close button on every device, like the other sheets that only dismiss.

iPhone and iPad bars are unchanged apart from the last two items: the priority and compression settings only matter when items don't fit.

Stack: #1318 → this PR → #1280.

Screenshots

Before After
Home, iPhone Duo folded landscape Home overflow before Home overflow after
Bookmarks in edit mode, iPhone Duo folded landscape Bookmarks edit before Bookmarks edit after
Reciter list in Audio Options, iPhone 18 Pro Reciter list before Reciter list after
Ayah notes sheet, iPhone 18 Pro Ayah notes before Ayah notes after

Testing

  • make format-lint, make build-no-sync and make build-sync.
  • NoorUITests, UIxTests, NotesFeatureTests, BookmarksFeatureTests and AdvancedAudioOptionsFeatureTests pass. New cases cover Done's priority, the overflow entry following the item's state, image and action, the tab bar compression while editing, and the notes sheet's opt-out.
  • Checked on the iPhone Duo simulator (folded landscape) and the iPhone 18 Pro simulator, iOS 27.2, as in the screenshots.

🤖 Generated with Claude Code

mohamede1945 and others added 4 commits November 18, 2026 11:11
When a bar runs out of room, like iPhone Duo's vertical bar in folded
landscape, the system moves items into a "•••" menu. Done went there
untinted, and icon-only items such as Add, Share, Reverse order, and
Choose Mushaf were listed as icons without a title.

Done now has high visibility priority, so it stays in the bar. Icon-only
items carry a titled menu entry that follows their enabled state and
image, so the menu reads "Add Collection" or "Choose Mushaf", and Next and
Previous turn off there too at the ends of the Quran. The bar still shows
only the icons, and priority only matters once the bar runs out of room,
so iPhone and iPad look the same. Notes' Share uses the new
NavigationBarButton.share and keeps its tint.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the tab bar and bar items share iPhone Duo's vertical bar, the system
compresses the items first, so in folded landscape Done could still land in
the overflow menu. Editing doesn't switch tabs, so while a list is in Edit
mode its navigation item prefers bar items, and the tab bar compresses to
the current tab instead. Without a vertical bar the setting has no effect,
so iPhone and iPad don't change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Audio Options pushes the reciter list as a view controller inside SwiftUI,
which laid it out inside the safe area. The list never saw the home
indicator or iPhone Duo's vertical bar column, so a white band showed below
it, and beside it on iPhone Duo.

The pushed list now ignores the side and bottom safe area and reads it
itself, like the reciter list from Settings, so its grouped background
reaches the sheet's edges while its rows stay inset. The top is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On iPhone Duo the ayah notes sheet reserved an empty column for the
vertical bar, so its content sat off-center with a wide right margin. The
sheet's only bar item, Edit, is text, which the vertical bar doesn't show,
and the medium detent has no status bar to share the column with. The
sheet now presents through a navigation controller that opts out of the
vertical bar, so it keeps a horizontal bar and centered content. Without a
vertical bar, like on iPhone and iPad, the opt-out changes nothing.

The sheet only dismisses, so it now has a leading Close, like the
translated verse sheet, on every device.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant