Skip to content

Extract validation logic from DataDictionary into DataDictionaryValidator - #1306

Open
konradbloor wants to merge 4 commits into
quickfix-j:masterfrom
konradbloor:feature/extract-datadictionary-validator
Open

Extract validation logic from DataDictionary into DataDictionaryValidator#1306
konradbloor wants to merge 4 commits into
quickfix-j:masterfrom
konradbloor:feature/extract-datadictionary-validator

Avoid constructing a `DataDictionaryValidator` per `DataDictionary.va…

539bdf0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 26, 2026 in 0s

70.92% (+0.49%) compared to 369182d

View this Pull Request on Codecov

70.92% (+0.49%) compared to 369182d

Details

Codecov Report

❌ Patch coverage is 93.18182% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.92%. Comparing base (369182d) to head (539bdf0).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rc/main/java/quickfix/DataDictionaryValidator.java 93.65% 1 Missing and 7 partials ⚠️
...xj-base/src/main/java/quickfix/DataDictionary.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1306      +/-   ##
============================================
+ Coverage     70.42%   70.92%   +0.49%     
- Complexity     2249     2281      +32     
============================================
  Files           159      160       +1     
  Lines          9065     9076      +11     
  Branches       1192     1193       +1     
============================================
+ Hits           6384     6437      +53     
+ Misses         2218     2190      -28     
+ Partials        463      449      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.