LOGBACK-992: do not delete the original file when compression fails - #1058
Open
aysha-afrah26 wants to merge 1 commit into
Open
LOGBACK-992: do not delete the original file when compression fails#1058aysha-afrah26 wants to merge 1 commit into
aysha-afrah26 wants to merge 1 commit into
Conversation
Signed-off-by: aysha-afrah26 <aysha26@digiscrypt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compression of a rolled log file fails (e.g. disk full), all three compression strategies swallow the exception and then delete the original file anyway leaving only a truncated, unusable archive. The rolled log data is permanently lost, and the leftover partial file blocks any retry with target compressed file exists already.
This makes the delete conditional on success: on failure the original file is kept and the partial archive is removed. Same intent as the long-open #273 (LOGBACK-992), which predates the current CompressionStrategy classes . this version targets the current code and adds a regression test (fails on master, passes with the fix). Related reports: #863, #921.