Remove references to hydra base, and add several updates #57
Open
knoxsp wants to merge 2 commits into
Open
Conversation
… larger, more complex models
pmslavin
approved these changes
Aug 27, 2025
pmslavin
left a comment
pmslavin
left a comment
Collaborator
There was a problem hiding this comment.
Couple of questions about (1) how use_cache is specified to run_network_scenario, and (2) when a dict is classed as a descriptor.
Comment on lines
441
to
+443
| elif isinstance(attr_value, dict): | ||
| if 'index' in attr_value and 'table' in attr_value: | ||
| return "DESCRIPTOR" |
Collaborator
There was a problem hiding this comment.
Certain types of dict datasets are classed as 'descriptor' depending on their keys?
Comment on lines
+41
to
+42
| def run_network_scenario(client, scenario_id, template_id, | ||
| solver=None, data_dir='/tmp', use_cache=False, **kwargs): |
Collaborator
There was a problem hiding this comment.
How do we set use_cache to True when we want to use it? Only the export_json cli command takes a --use-cache arg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainly to work with larger, more complex models
Remove attaching parameters because parameter names are changed on import, resulting in broken parameter references from model parameters referencing the old parameter name