[ExecuTorch] Complete Muse Glimmer rename - #21863
Conversation
Update remaining comments and test documentation to use the current model name.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21863
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Unclassified FailureAs of commit dedcc5b with merge base ed65b12 ( UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR finishes the “Muse Glimmer” rename cleanup by updating remaining test/doc comments that still referenced legacy “Onyx” terminology in the Muse Glimmer example + runtime.
Changes:
- Update Muse Glimmer vision test documentation/comments to reference
MuseGlimmerVisionEncoderconsistently. - Refresh prompt-golden / prompt contract documentation in the Muse Glimmer test helpers.
- Update a runtime runner comment to reference
MuseGlimmerConfiginstead ofOnyxConfig.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/models/muse-glimmer/tests/test_vision_tower.py | Updates docstring/comments to Muse Glimmer terminology in the vision encoder unit tests. |
| examples/models/muse-glimmer/tests/test_vision_precompute.py | Updates test docstring + inline reference comment to Muse Glimmer naming. |
| examples/models/muse-glimmer/tests/prompt_cases.py | Updates prompt-contract comment for image patch token formatting. |
| examples/models/muse-glimmer/tests/gen_prompt_golden.py | Removes a large “re-validating after regeneration” doc section from the module docstring. |
| examples/models/muse-glimmer/runtime/runners/solo.cpp | Updates a comment to reference Muse Glimmer config naming. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # Tokens the image span costs beyond the patches themselves. Zero: the canonical | ||
| # format is a bare <|patch|> run, which is what OnyxProcessor.replace_image_token | ||
| # emits and what meta_reference_implementation splices on. | ||
| # format is a bare <|patch|> run, which is what the Muse Glimmer processor's | ||
| # replace_image_token method emits and what meta_reference_implementation splices on. |
| } | ||
|
|
||
| // Muse Glimmer image special-token ids (from the tokenizer / OnyxConfig). | ||
| // Muse Glimmer image special-token ids (from the tokenizer / MuseGlimmerConfig). |
Update remaining comments and test documentation