Skip to content

[ExecuTorch] Complete Muse Glimmer rename - #21863

Open
digantdesai wants to merge 1 commit into
mainfrom
muse_glimmer_final_rename
Open

[ExecuTorch] Complete Muse Glimmer rename#21863
digantdesai wants to merge 1 commit into
mainfrom
muse_glimmer_final_rename

Conversation

@digantdesai

Copy link
Copy Markdown
Contributor

Update remaining comments and test documentation

Update remaining comments and test documentation to use the current model name.
Copilot AI lite review requested due to automatic review settings August 15, 2026 02:19
@pytorch-bot

pytorch-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21863

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Unclassified Failure

As of commit dedcc5b with merge base ed65b12 (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 15, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR finishes the “Muse Glimmer” rename cleanup by updating remaining test/doc comments that still referenced legacy “Onyx” terminology in the Muse Glimmer example + runtime.

Changes:

  • Update Muse Glimmer vision test documentation/comments to reference MuseGlimmerVisionEncoder consistently.
  • Refresh prompt-golden / prompt contract documentation in the Muse Glimmer test helpers.
  • Update a runtime runner comment to reference MuseGlimmerConfig instead of OnyxConfig.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
examples/models/muse-glimmer/tests/test_vision_tower.py Updates docstring/comments to Muse Glimmer terminology in the vision encoder unit tests.
examples/models/muse-glimmer/tests/test_vision_precompute.py Updates test docstring + inline reference comment to Muse Glimmer naming.
examples/models/muse-glimmer/tests/prompt_cases.py Updates prompt-contract comment for image patch token formatting.
examples/models/muse-glimmer/tests/gen_prompt_golden.py Removes a large “re-validating after regeneration” doc section from the module docstring.
examples/models/muse-glimmer/runtime/runners/solo.cpp Updates a comment to reference Muse Glimmer config naming.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 24 to +26
# Tokens the image span costs beyond the patches themselves. Zero: the canonical
# format is a bare <|patch|> run, which is what OnyxProcessor.replace_image_token
# emits and what meta_reference_implementation splices on.
# format is a bare <|patch|> run, which is what the Muse Glimmer processor's
# replace_image_token method emits and what meta_reference_implementation splices on.
}

// Muse Glimmer image special-token ids (from the tokenizer / OnyxConfig).
// Muse Glimmer image special-token ids (from the tokenizer / MuseGlimmerConfig).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants