Enable logging in MPS example runner builds - #21861
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21861
Note: Links to docs will display an error until the docs builds have been completed.
|
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
|
@pytorchbot label "release notes: examples" |
Fixes #12764.
The MPS example runner build defaults to
Release, and ExecuTorch disables logging by default for non-Debug builds. As a result, runtime failures such as an invalid model path can exit without theET_LOGdiagnostics emitted by the runner.Pass
-DEXECUTORCH_ENABLE_LOGGING=ONwhen building the ExecuTorch runtime used by the MPS runner. This keeps Release optimization while retaining runtime diagnostics.Validation: the current CMake preset sets
EXECUTORCH_ENABLE_LOGGINGoff for Release builds and translates that toET_LOG_ENABLED=0;runtime/platform/log.henables logging when that define is not disabled. This change explicitly opts the runner build back into logging.