Skip to content

Enable logging in MPS example runner builds - #21861

Open
sylvesterkaczmarek wants to merge 1 commit into
pytorch:mainfrom
sylvesterkaczmarek:fix-12764-mps-runner-logging
Open

Enable logging in MPS example runner builds#21861
sylvesterkaczmarek wants to merge 1 commit into
pytorch:mainfrom
sylvesterkaczmarek:fix-12764-mps-runner-logging

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Fixes #12764.

The MPS example runner build defaults to Release, and ExecuTorch disables logging by default for non-Debug builds. As a result, runtime failures such as an invalid model path can exit without the ET_LOG diagnostics emitted by the runner.

Pass -DEXECUTORCH_ENABLE_LOGGING=ON when building the ExecuTorch runtime used by the MPS runner. This keeps Release optimization while retaining runtime diagnostics.

Validation: the current CMake preset sets EXECUTORCH_ENABLE_LOGGING off for Release builds and translates that to ET_LOG_ENABLED=0; runtime/platform/log.h enables logging when that define is not disabled. This change explicitly opts the runner build back into logging.

@pytorch-bot

pytorch-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21861

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 16 Awaiting Approval

As of commit a6a2b95 with merge base ed65b12 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla

meta-cla Bot commented Aug 15, 2026

Copy link
Copy Markdown

Hi @sylvesterkaczmarek!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@linux-foundation-easycla

Copy link
Copy Markdown

CLA Not Signed

Copy link
Copy Markdown
Author

@pytorchbot label "release notes: examples"

@pytorch-bot pytorch-bot Bot added the release notes: examples Changes to any of our example LLMs integrations, such as Llama3 and Llava label Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: examples Changes to any of our example LLMs integrations, such as Llama3 and Llava

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MPS example runner doesn't print logs

2 participants