Qualcomm AI Engine Direct - Fix LPAI Partitioner QDQ Ops - #21838
Open
winskuo-quic wants to merge 1 commit into
Open
Qualcomm AI Engine Direct - Fix LPAI Partitioner QDQ Ops#21838winskuo-quic wants to merge 1 commit into
winskuo-quic wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21838
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 71029dc with merge base abc5586 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We made assumption that source node always saves quant_attrs target using quant_node, however, if a node's input is a constant, it will be using dequant_node's quant attrs. This assumption causes some error during node creation when are creating qdq nodes. To resolve this issue, we make quant and de-quant node explicit instead of relying on source node's quant attributes target.
Test plan
Passing UT for lpai paritioner