Skip to content

Fix 32-bit index overflow and error-path leak in forced_align (CPU) #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
happyarts wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix 32-bit index overflow and error-path leak in forced_align (CPU) #4209

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df15555
Fix 32-bit loop index overflow in forced_align CPU init loops
happyarts Jul 22, 2026
362f1a8
Own the DP buffers, and size them only after validating the input
Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/libtorchaudio/forced_align/cpu/compute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@ void forced_align_impl(
const auto S = 2 * L + 1;

auto alphas_a = new scalar_t[2 * S]; // scalar_t is just logProbs.dtype()
for (int i = 0; i < 2 * S; i++) {
for (int64_t i = 0; i < 2 * S; i++) {
alphas_a[i] = kNegInfinity;
}
Comment thread
pearu marked this conversation as resolved.
Outdated

auto backPtr_a = new int8_t[T * S];
for (int i = 0; i < T * S; i++) {
for (int64_t i = 0; i < T * S; i++) {
backPtr_a[i] = -1;
}
auto logProbs_a = torchaudio::accessor<scalar_t, 3>(logProbs);
Expand Down