Conversation
ordinal() computed the suffix from value % 10 and value % 100, but Python's modulo on a negative number gave the wrong digit, so e.g. ordinal(-9) was "-9st" and ordinal(-1) was "-1th". Use the magnitude instead.
Member
|
Please see questions on duplicate #321. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
ordinal()on a negative integer gives the wrong suffix:The suffix is chosen from
value % 10andvalue % 100, but Python's modulo of a negative number counts up from the next lower multiple (-9 % 10 == 1,-1 % 10 == 9), so the digit used for the lookup is wrong for every negative value.Computing the digit from
abs(value)fixes it while leaving non-negative values, the 11/12/13 special case, and the non-finite / non-numeric paths unchanged:Added the negative cases to
test_ordinal; the fulltest_number.pysuite passes.