Skip to content

Remove the leftover format placeholder from intword units #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 2 commits into from
Sep 16, 2026
+75 −58
Merged

Remove the leftover format placeholder from intword units #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
863b132
Remove the leftover format placeholder from intword units
VenishPaneliya Aug 25, 2026
0e91641
Test all locales, and skip when file not found
hugovk Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions src/humanize/locale/bn_BD/LC_MESSAGES/humanize.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,57 +121,57 @@ msgstr "তম"
#: src/humanize/number.py:178
msgid "thousand"
msgid_plural "thousand"
msgstr[0] "%d হাজার"
msgstr[1] "%d হাজার"
msgstr[0] "হাজার"
msgstr[1] "হাজার"

#: src/humanize/number.py:179
#, fuzzy
msgid "million"
msgid_plural "million"
msgstr[0] "%d মিলিয়ন"
msgstr[1] "%d মিলিয়ন"
msgstr[0] "মিলিয়ন"
msgstr[1] "মিলিয়ন"

#: src/humanize/number.py:180
msgid "billion"
msgid_plural "billion"
msgstr[0] "%d বিলিয়ন"
msgstr[1] "%d বিলিয়ন"
msgstr[0] "বিলিয়ন"
msgstr[1] "বিলিয়ন"

#: src/humanize/number.py:181
msgid "trillion"
msgid_plural "trillion"
msgstr[0] "%d ট্রিলিয়ন"
msgstr[1] "%d ট্রিলিয়ন"
msgstr[0] "ট্রিলিয়ন"
msgstr[1] "ট্রিলিয়ন"

#: src/humanize/number.py:182
msgid "quadrillion"
msgid_plural "quadrillion"
msgstr[0] "%d কোয়াড্রিলিয়ন"
msgstr[1] "%d কোয়াড্রিলিয়ন"
msgstr[0] "কোয়াড্রিলিয়ন"
msgstr[1] "কোয়াড্রিলিয়ন"

#: src/humanize/number.py:183
msgid "quintillion"
msgid_plural "quintillion"
msgstr[0] "%d কুইন্টিলিয়ন"
msgstr[1] "%d কুইন্টিলিয়ন"
msgstr[0] "কুইন্টিলিয়ন"
msgstr[1] "কুইন্টিলিয়ন"

#: src/humanize/number.py:184
msgid "sextillion"
msgid_plural "sextillion"
msgstr[0] "%d সেক্সটিলিয়ন"
msgstr[1] "%d সেক্সটিলিয়ন"
msgstr[0] "সেক্সটিলিয়ন"
msgstr[1] "সেক্সটিলিয়ন"

#: src/humanize/number.py:185
msgid "septillion"
msgid_plural "septillion"
msgstr[0] "%d সেপটিলিয়ন"
msgstr[1] "%d সেপটিলিয়ন"
msgstr[0] "সেপটিলিয়ন"
msgstr[1] "সেপটিলিয়ন"

#: src/humanize/number.py:186
msgid "octillion"
msgid_plural "octillion"
msgstr[0] "%d ওকটিলিয়ন"
msgstr[1] "%d ওকটিলিয়ন"
msgstr[0] "ওকটিলিয়ন"
msgstr[1] "ওকটিলিয়ন"

#: src/humanize/number.py:187
msgid "nonillion"
Expand Down
40 changes: 20 additions & 20 deletions src/humanize/locale/ko_KR/LC_MESSAGES/humanize.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ msgstr[1] ""
#: src/humanize/number.py:179
msgid "million"
msgid_plural "million"
msgstr[0] "%(value)s million"
msgstr[1] "%(value)s million"
msgstr[0] "million"
msgstr[1] "million"

#: src/humanize/number.py:180
msgid "billion"
Expand All @@ -161,64 +161,64 @@ msgstr[1] "milliard"
#, fuzzy
msgid "trillion"
msgid_plural "trillion"
msgstr[0] "%(value)s billion"
msgstr[1] "%(value)s billion"
msgstr[0] "billion"
msgstr[1] "billion"

#: src/humanize/number.py:182
#, fuzzy
msgid "quadrillion"
msgid_plural "quadrillion"
msgstr[0] "%(value)s quadrillion"
msgstr[1] "%(value)s quadrillion"
msgstr[0] "quadrillion"
msgstr[1] "quadrillion"

#: src/humanize/number.py:183
#, fuzzy
msgid "quintillion"
msgid_plural "quintillion"
msgstr[0] "%(value)s quintillion"
msgstr[1] "%(value)s quintillion"
msgstr[0] "quintillion"
msgstr[1] "quintillion"

#: src/humanize/number.py:184
#, fuzzy
msgid "sextillion"
msgid_plural "sextillion"
msgstr[0] "%(value)s sextillion"
msgstr[1] "%(value)s sextillion"
msgstr[0] "sextillion"
msgstr[1] "sextillion"

#: src/humanize/number.py:185
#, fuzzy
msgid "septillion"
msgid_plural "septillion"
msgstr[0] "%(value)s septillion"
msgstr[1] "%(value)s septillion"
msgstr[0] "septillion"
msgstr[1] "septillion"

#: src/humanize/number.py:186
#, fuzzy
msgid "octillion"
msgid_plural "octillion"
msgstr[0] "%(value)s octillion"
msgstr[1] "%(value)s octillion"
msgstr[0] "octillion"
msgstr[1] "octillion"

#: src/humanize/number.py:187
#, fuzzy
msgid "nonillion"
msgid_plural "nonillion"
msgstr[0] "%(value)s nonillion"
msgstr[1] "%(value)s nonillion"
msgstr[0] "nonillion"
msgstr[1] "nonillion"

#: src/humanize/number.py:188
#, fuzzy
msgid "decillion"
msgid_plural "decillion"
msgstr[0] "%(value)s décillion"
msgstr[1] "%(value)s décillion"
msgstr[0] "décillion"
msgstr[1] "décillion"

#: src/humanize/number.py:189
#, fuzzy
msgid "googol"
msgid_plural "googol"
msgstr[0] "%(value)s gogol"
msgstr[1] "%(value)s gogol"
msgstr[0] "gogol"
msgstr[1] "gogol"

#: src/humanize/number.py:301
msgid "zero"
Expand Down
40 changes: 20 additions & 20 deletions src/humanize/locale/vi_VN/LC_MESSAGES/humanize.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ msgstr[1] "nghìn"
#: src/humanize/number.py:179
msgid "million"
msgid_plural "million"
msgstr[0] "%(value)s triệu"
msgstr[1] "%(value)s triệu"
msgstr[0] "triệu"
msgstr[1] "triệu"

#: src/humanize/number.py:180
msgid "billion"
Expand All @@ -140,63 +140,63 @@ msgstr[1] "tỷ"
#: src/humanize/number.py:181
msgid "trillion"
msgid_plural "trillion"
msgstr[0] "%(value)s nghìn tỷ"
msgstr[1] "%(value)s nghìn tỷ"
msgstr[0] "nghìn tỷ"
msgstr[1] "nghìn tỷ"

#: src/humanize/number.py:182
msgid "quadrillion"
msgid_plural "quadrillion"
msgstr[0] "%(value)s triệu tỷ"
msgstr[1] "%(value)s triệu tỷ"
msgstr[0] "triệu tỷ"
msgstr[1] "triệu tỷ"

#: src/humanize/number.py:183
#, fuzzy
msgid "quintillion"
msgid_plural "quintillion"
msgstr[0] "%(value)s tỷ tỷ"
msgstr[1] "%(value)s tỷ tỷ"
msgstr[0] "tỷ tỷ"
msgstr[1] "tỷ tỷ"

#: src/humanize/number.py:184
#, fuzzy
msgid "sextillion"
msgid_plural "sextillion"
msgstr[0] "%(value)s sextillion"
msgstr[1] "%(value)s sextillion"
msgstr[0] "sextillion"
msgstr[1] "sextillion"

#: src/humanize/number.py:185
#, fuzzy
msgid "septillion"
msgid_plural "septillion"
msgstr[0] "%(value)s septillion"
msgstr[1] "%(value)s septillion"
msgstr[0] "septillion"
msgstr[1] "septillion"

#: src/humanize/number.py:186
#, fuzzy
msgid "octillion"
msgid_plural "octillion"
msgstr[0] "%(value)s octillion"
msgstr[1] "%(value)s octillion"
msgstr[0] "octillion"
msgstr[1] "octillion"

#: src/humanize/number.py:187
#, fuzzy
msgid "nonillion"
msgid_plural "nonillion"
msgstr[0] "%(value)s nonillion"
msgstr[1] "%(value)s nonillion"
msgstr[0] "nonillion"
msgstr[1] "nonillion"

#: src/humanize/number.py:188
#, fuzzy
msgid "decillion"
msgid_plural "decillion"
msgstr[0] "%(value)s décillion"
msgstr[1] "%(value)s décillion"
msgstr[0] "décillion"
msgstr[1] "décillion"

#: src/humanize/number.py:189
#, fuzzy
msgid "googol"
msgid_plural "googol"
msgstr[0] "%(value)s gogol"
msgstr[1] "%(value)s gogol"
msgstr[0] "gogol"
msgstr[1] "gogol"

#: src/humanize/number.py:301
msgid "zero"
Expand Down
17 changes: 17 additions & 0 deletions tests/test_i18n.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@

import datetime as dt
import importlib
import pathlib

import pytest
from freezegun import freeze_time

import humanize

LOCALE_DIR = pathlib.Path(humanize.i18n.__file__).parent / "locale"

with freeze_time("2020-02-02"):
NOW = dt.datetime.now(tz=dt.timezone.utc)

Expand Down Expand Up @@ -334,3 +337,17 @@ def test_none_locale(self) -> None:
humanize.i18n.deactivate()

assert test_str == humanize.naturaltime(three_seconds)


@pytest.mark.parametrize(
"locale", sorted(p.name for p in LOCALE_DIR.iterdir() if p.is_dir())
)
def test_intword_unit_has_no_format_placeholder(locale: str) -> None:
try:
humanize.i18n.activate(locale)
for value in (1_000, 1_000_000, 1_000_000_000, 10**12, 10**15, 10**100):
assert "%" not in humanize.intword(value)
except FileNotFoundError:
pytest.skip("Generate .mo with scripts/generate-translation-binaries.sh")
finally:
humanize.i18n.deactivate()