Skip to content

fix: catch OverflowError in naturalsize() for very large integers #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
koteshyelamati wants to merge 2 commits into from
+6 −1
Closed

fix: catch OverflowError in naturalsize() for very large integers #355

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fd876c
fix: catch OverflowError in naturalsize() for very large integers
koteshyelamati Jul 20, 2026
5325357
Merge branch 'main' into patch-1
hugovk Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/humanize/filesize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@ def naturalsize(
suffix = suffixes["decimal"]

base = 1024 if (gnu or binary) else 1000
bytes_ = float(value)
try:
bytes_ = float(value)
except (ValueError, OverflowError) as exc:
raise ValueError(
f"naturalsize() argument must be a number, not {type(value).__name__!r}"
) from exc
Comment on lines +90 to +95

@hugovk hugovk Sep 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't add support, just re-raises an OverflowError as ValueError with an incorrect error:

>>> humanize.naturalsize(10**309)
ValueError: naturalsize() argument must be a number, not 'int'

An int is a number.

>>> humanize.naturalsize("abc")
ValueError: naturalsize() argument must be a number, not 'str'

Numeric strings are documented as an acceptable input.

abs_bytes = abs(bytes_)

if abs_bytes == 1 and not gnu:
Expand Down