add docker#1148
Closed
KrishMunot wants to merge 2 commits into
Closed
Conversation
Collaborator
|
This looks great, but would you mind adding some sort of doc on how to use it? |
Contributor
Author
|
Yes, I will add it soon. |
Collaborator
|
Hi @KrishMunot, would you mind cherry-picking corona10's original commit, rather than copying the file and creating a new commit? You should be able to do it with Could you also add a small doc somewhere? I'm pretty hesitant to merge something like this without at least a tiny amount of documentation, since otherwise we/I won't remember what's going on with it and it is likely to just get removed. Even just corona10's two lines of instruction from #1099 would be great to have in the readme. |
Collaborator
|
I'm going to close this and we can keep discussing on #1099 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.