Skip to content

add docker#1148

Closed
KrishMunot wants to merge 2 commits into
pyston:masterfrom
KrishMunot:patch-1
Closed

add docker#1148
KrishMunot wants to merge 2 commits into
pyston:masterfrom
KrishMunot:patch-1

Conversation

@KrishMunot

Copy link
Copy Markdown
Contributor

No description provided.

@kmod

kmod commented May 6, 2016

Copy link
Copy Markdown
Collaborator

This looks great, but would you mind adding some sort of doc on how to use it?

@KrishMunot

Copy link
Copy Markdown
Contributor Author

Yes, I will add it soon.
Can you merge this while we are at it?
Thanks! 😃

@corona10

corona10 commented May 7, 2016

Copy link
Copy Markdown

@kmod It looks like same docker code when I made PR as #1099 but it looks good. :-)

@kmod

kmod commented May 9, 2016

Copy link
Copy Markdown
Collaborator

Hi @KrishMunot, would you mind cherry-picking corona10's original commit, rather than copying the file and creating a new commit? You should be able to do it with

git fetch origin eae40ee9
git cherry-pick eae40ee9

Could you also add a small doc somewhere? I'm pretty hesitant to merge something like this without at least a tiny amount of documentation, since otherwise we/I won't remember what's going on with it and it is likely to just get removed. Even just corona10's two lines of instruction from #1099 would be great to have in the readme.

@kmod

kmod commented Jun 8, 2016

Copy link
Copy Markdown
Collaborator

I'm going to close this and we can keep discussing on #1099

@kmod kmod closed this Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants