FEAT: Poisson process time of arrival and random reflection sign - #176
Open
mberz wants to merge 15 commits into
Open
FEAT: Poisson process time of arrival and random reflection sign#176mberz wants to merge 15 commits into
mberz wants to merge 15 commits into
Conversation
as the expected number of reflections in a room
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new parametric utilities for simulating reflection arrival times via a (capped) non-homogeneous Poisson process and for converting arrival times into a ternary (-1/0/1) reflection sequence suitable for signal-based workflows in pyrato.
Changes:
- Added
_start_time_of_arrival_poisson_processandtime_of_arrival_poisson_processfor sampling reflection arrival times (with optional reflection-rate limiting). - Added
ternary_reflection_sequenceto map arrival times to discrete samples with random ±1 signs. - Added unit tests covering start-time calculation, sampling reproducibility, bounds, rate limiting, and ternary sequence behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
pyrato/parametric.py |
Introduces Poisson-process TOA sampling and ternary reflection sequence generation. |
tests/test_parametric.py |
Adds tests for the new TOA and ternary-sequence functionality. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Supports drawing from different distributions
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
None
Changes proposed in this pull request:
Dependencies