feat: add fish 4.9.2 - #21
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The workflow has unresolved latest-alias and cross-architecture binary issues.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Fish 4.9.2 as an Alpine edge binary image and documents the image tag.
Changes:
- Adds Fish 4.9.2 to the build matrix.
- Documents Fish 4.9.2 in the README.
File summaries
| File | Summary |
|---|---|
README.md |
Documents Fish 4.9.2. |
.github/workflows/build-images.yml |
Adds the binary build, but has a moderate issue (3 votes) with latest alias selection and a critical issue (2 votes) where non-amd64 images download an x86_64 binary. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| { fish: 3.7.1, alpine: 3.21 }, | ||
| { fish: 4.0.2, alpine: 3.22 }, | ||
| # New versions built with pre-built binary | ||
| { fish: 4.9.2, alpine: "edge", binary: true }, |
| { fish: 3.7.1, alpine: 3.21 }, | ||
| { fish: 4.0.2, alpine: 3.22 }, | ||
| # New versions built with pre-built binary | ||
| { fish: 4.9.2, alpine: "edge", binary: true }, |
edouard-lopez
force-pushed
the
add-fish-4.9.2
branch
from
September 14, 2026 18:12
2b5a75c to
5f6fb47
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edouard-lopez
force-pushed
the
add-fish-4.9.2
branch
from
September 14, 2026 18:49
5f6fb47 to
4c7c541
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Fish 4.9.2 using the pre-built binary on Alpine edge and documents the image tag.