Skip to content

feat: comment on PRs blocked by required_signatures naming the unsigned commit and the fix #70

Description

@avrabe

What

When a PR is un-mergeable because of the required_signatures rule, temper should comment on the PR naming the offending commit(s) and the fix ("commit X is unsigned/unverifiable — rebase to re-sign"). Today the state is illegible: the PR sits mergeStateStatus: BLOCKED with every check green, and nothing — not the check list, not reviewDecision, not the merge button — names signatures.

Detection is straightforward from the API temper already uses: blocked merge state + all green checks + a commit in the range with verification.verified == false (or %G? ∉ {G}).

Why — three repos hit it independently this week

  • gale (#323): a -c commit.gpgsign=false commit left a PR BLOCKED with all 61 checks green; diagnosed only via git log --format='%G?' plus the protection API. "Keep the rule; the wish is that the blocked state say why."
  • ordeal (#130): a PR sat BLOCKED-all-green from an unverifiable signature (email identity mismatch); fix was rebase-to-re-sign. "A temper bot comment… would save every future maintainer the same diagnosis."
  • synth (#1132): "an unsigned commit is silently unmergeable and surfaces much later as an opaque 'base branch policy prohibits the merge'."

All three explicitly keep the signed-commits rule — this is purely a legibility fix on a control everyone endorses.

From the 2026-09 org feedback round (temper#62).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions