fix: emit canonical Paykit requests and retry initial links - #2
Open
ben-kaufman wants to merge 4 commits into
Open
fix: emit canonical Paykit requests and retry initial links#2ben-kaufman wants to merge 4 commits into
ben-kaufman wants to merge 4 commits into
Conversation
ben-kaufman
force-pushed
the
codex/canonical-paykit-btc-asset
branch
from
August 6, 2026 19:17
673b0cd to
41cda25
Compare
Author
|
@jvsena42 could you please review the current head? The rapid initial private-link retry, canonical endpoint changes, and regression coverage have all been exercised in the clean iOS and Android Locks → Paykit → Bitkit E2E flow. |
ovitrif
approved these changes
Aug 6, 2026
ovitrif
left a comment
There was a problem hiding this comment.
Approved. Canonical lowercase btc assets, network-specific endpoint IDs, {value} private payloads, and the bounded rapid link_establishment retry preserve the intended Paykit request and outbox behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
btcPaykit assets while preserving Locks’ uppercaseBTCcriterion boundary{ "value": ... }payload expected by wallet adapterslink_establishmentevery second during a bounded initial handshake window before returning to normal exponential backoffVerification
cargo fmt --all -- --checkcargo check --workspacecargo test -p paykit-server link_establishment_retries_rapidly_before_restarting_exponential_backoffcargo clippy --workspace --all-targets -- -D warningsFound while running the clean Locks → Paykit Server → Bitkit E2E flow.