Draft
Add test that awaitDocumentPushed() resolves after a push conflict is resolved#8739
Conversation
Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
…limit Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pubkey
July 6, 2026 09:56
View session
Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Contributor
|
Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Owner
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Contributor
Author
Merge conflicts resolved in a4e8297. The only conflict was in the type imports of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test covering the case where a document push first returns a conflict: after the conflict is resolved,
awaitDocumentPushed()must still resolve.Changes
test/unit/replication.test.ts: New testshould resolve after a push conflict was resolvedin the.awaitDocumentPushed()suite:hadConflictflag in the push handler).awaitDocumentPushed(doc)resolves afterwards and the resolved state reached the master.test:fast:memoryrun over the open-collections limit (COL23).orga/changelog/add-await-document-pushed-conflict-test.md: Changelog entry linking issue Feature request: awaitable per-write push acknowledgement (opt-in write-through for replication) #8632.Test is stable across repeated runs, including the
memory-random-delaystorage.