Quality-guided phase unwrapping#639
Open
pierrethibault wants to merge 1 commit into
Open
Conversation
Contributor
|
@pierrethibault I agree that wrapping this into a real Python extension is the better option! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed at the end of the Hackathon 2025, I am adding here my implementation of the quality-quided phase unwrapping method.
This is manifestly not ready to pull, because I still need to figure out how this will be integrated in the installation. It looks like there are two main options:
build_extthat compiles the file, and use a wrapper withctypes. For now the result looks messy, because compiled libraries have different names on different platforms and some code must be added to search for the shared library.Currently I am leaning towards option 2, which will give a cleaner final result, but I know that Benedikt @daurer suggested using ctypes. Waiting for input!
Todo: