Repository navigation
Conversation
added 5 commits
October 12, 2026 12:18
Agent posts into group conversations, and agent participant rows in them, now follow the agent's message mode: - none: never posts to or joins a group conversation. - project, hub: unchanged; posting adds the agent as a participant. - lineage, branch: posts only to a group conversation it already belongs to; posting never adds it. It is added only by a human whom its mode lets message it (ancestry user, project owner, super-admin). One shared decision (group_message_mode.go) is used by the outbound and agent-message handlers, the participant API, conversation create, and mention fan-out. Refusals return 403 message_denied. Tracked in #4413
- check the thread conversation exists before resolving it for lineage and branch senders; refuse none and unknown modes directly - read the inbound thread sender once - decide human adders by identity type - answer 500 on a sender lookup fault - tests: mention registration, new thread with no conversation written, create writes no conversation on refusal, concrete success statuses - docs: posting by conversation ID adds project and hub agents
ptone
marked this pull request as draft
October 12, 2026 17:09
ptone
marked this pull request as ready for review
October 12, 2026 17:12
ptone
marked this pull request as draft
October 12, 2026 19:02
ptone
marked this pull request as ready for review
October 12, 2026 19:43
Owner
Author
|
Closed: merged upstream in GoogleCloudPlatform#3433 (2180fc8). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent posts to group conversations, and agent participant rows in them, now follow the agent's message mode:
none: never posts to or joins a group conversation.project,hub: unchanged.lineage,branch: post only where they are already a participant, and posting never adds them. They are added only by a human their mode lets message them (ancestry user, project owner, super-admin).One shared check in
pkg/hub/group_message_mode.gocovers the message handlers, the participant API, conversation create and mention fan-out. Refusals return 403message_denied. Docs updated.Tracked in #4413