Fix preview split for commented method chains#5218
Open
ishaanlabs-gg wants to merge 1 commit into
Open
Conversation
ishaanlabs-gg
force-pushed
the
fix-method-chain-comment-split
branch
from
cd5571e to
e54ab69
Compare
Collaborator
|
This is a design decision, so we need to discuss the pros and cons of both styles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3998.
When a standalone comment appears between chained method calls, Black could split the
same leading call differently depending on whether another chained call followed the
comment. This adds a preview-gated formatter feature so commented method chains split
the first trailer consistently.
The change is intentionally limited to dotted delimiter splitting when the line contains
a standalone comment. Stable style remains unchanged.
Checklist - did you ...
--previewstyle, following the stability policy?CHANGES.mdif necessary?Validation:
PYTHONPYCACHEPREFIX=.pycache-tmp /Volumes/STOREJET/2/Dependencies/black-3998-venv/bin/python -m pytest tests/test_format.py -k preview_method_chain_comment -qPYTHONPYCACHEPREFIX=.pycache-tmp /Volumes/STOREJET/2/Dependencies/black-3998-venv/bin/python -m pytest tests/test_docs.py tests/test_schema.py -qPYTHONPYCACHEPREFIX=.pycache-tmp /Volumes/STOREJET/2/Dependencies/black-3998-venv/bin/python -m pytest tests/test_format.py -qgit diff --check