Repository navigation
Add espejote-managed dynamic fact for cluster CA - #12
Merged
Merged
Conversation
HappyTetrahedron
added
bump:minor
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
3 of 4 tasks
simu
requested changes
Sep 29, 2026
simu
left a comment
simu
left a comment
Member
There was a problem hiding this comment.
See inline for some suggestions for more appropriate naming (I think I found all locations that need those renames, but I'm not 100% sure)
Co-authored-by: Simon Gerber <gesimu@gmail.com>
simu
requested changes
Sep 29, 2026
simu
left a comment
simu
left a comment
Member
There was a problem hiding this comment.
Implementation LGTM. I'd feel better if this was tested on the Talos Lab before we merge and release the change.
Also, please update the parameters docs to explain the new clusterName parameter. Ideally, the docs for that parameter should also explain the new feature.
2 of 7 tasks
Contributor
Author
|
Docs added. I've also rolled this out on the lab, it works now that I've fixed the manifest output path. |
simu
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.