Restructure Kustomize clusterctl CRD label patch - #12
Merged
Merged
Conversation
simu
force-pushed
the
feat/lib/crd-helpers
branch
from
September 11, 2026 09:43
3c418c4 to
1dd8c6e
Compare
simu
force-pushed
the
fix/clusterctl-label-patch
branch
from
September 11, 2026 09:43
c2ef54d to
5ba2473
Compare
This was referenced Sep 11, 2026
Merged
simu
added a commit
to projectsyn/component-capi-provider-talos
that referenced
this pull request
Sep 14, 2026
simu
force-pushed
the
fix/clusterctl-label-patch
branch
from
September 14, 2026 11:43
5ba2473 to
1314b06
Compare
simu
force-pushed
the
feat/lib/crd-helpers
branch
2 times, most recently
from
September 14, 2026 11:48
2d5ebc5 to
1b3cc19
Compare
simu
force-pushed
the
fix/clusterctl-label-patch
branch
from
September 14, 2026 11:48
1314b06 to
cd3a963
Compare
HappyTetrahedron
approved these changes
Sep 15, 2026
HappyTetrahedron
left a comment
HappyTetrahedron
left a comment
There was a problem hiding this comment.
Neat, this makes more sense :D
The new structure allows users to apply the full patch by just merging the object provided by the component library into the output of `com.Kustomization()`. Note that this is a breaking change for any components that already use the previous version of the patch.
simu
force-pushed
the
fix/clusterctl-label-patch
branch
from
September 15, 2026 09:42
cd3a963 to
0689317
Compare
simu
added a commit
to projectsyn/component-capi-provider-talos
that referenced
this pull request
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new structure allows users to apply the full patch by just merging the object provided by the component library into the output of
com.Kustomization().Note that this is a breaking change for any components that already use the previous version of the patch.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.