Handle duplicate Mnesia push sessions#4586
Merged
Merged
Conversation
Collaborator
|
Hi @catap, many thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
p1bot
added
the
cla-missing
Contributor
Author
|
I will signed it, but changes are quite trivial and I think it can be called "public domain". |
Member
|
There was a problem when building installers, I've fixed that now on master branch. Can you rebase your PR against master? |
Delete all existing push sessions for the same account, service, and node before storing a replacement; make lookup tolerate legacy duplicate rows by selecting the newest session. Fixes processone#4584
catap
force-pushed
the
mnesia-publish-duplicates
branch
from
f4fec37 to
9a70685
Compare
Contributor
Author
|
@badlop here it is. FWI I run it on my setup for a few days, and haven't see any issue anymore. |
Collaborator
|
You did it @catap! Thank you for signing the ProcessOne Contribution License Agreement. We will have a look at your contribution! |
p1bot
removed
the
cla-missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete all existing push sessions for the same account, service, and node before storing a replacement; make lookup tolerate legacy duplicate rows by selecting the newest session.
Fixes #4584