improve Date.add and Date.sub - #392
Open
Joshix-1 wants to merge 10 commits into
Open
Conversation
- Improve speed for both when adding many years worth of days/weeks
- Date.add now works with the same units Date.sub supports
- Prevent Year.prev and Year.next from wrapping around or panicing
- fix panic/overflow when subbing too many years ("@1970-01-01 - (2^63) years" was 1970-01-01)
- add some more tests
This reverts commit 9db86b6.
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
builds on top of #391
Checklist