Skip to content

Fix DOS in Date.add and Date.sub #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Joshix-1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix DOS in Date.add and Date.sub #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3036374
test interrupt in Date.add as it can take a long time
Joshix-1 Aug 4, 2026
b7efc5e
test for interrupt in Date.sub
Joshix-1 Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/date.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ pub(crate) use day_of_week::DayOfWeek;
pub(crate) use month::Month;
use year::Year;

use crate::interrupt::test_int;
use crate::{Interrupt, error::FendError, ident::Ident, result::FResult, value::Value};

#[derive(Copy, Clone, Eq, PartialEq)]
Expand Down Expand Up @@ -203,6 +204,7 @@ impl Date {
let num_days = rhs.try_as_usize_unit(int)?;
let mut result = self;
for _ in 0..num_days {
test_int(int)?;
result = result.next();
}
Ok(Value::Date(result))
Expand All @@ -219,6 +221,7 @@ impl Date {
let mut result = self;
for _ in 0..num_days {
result = result.prev();
test_int(int)?;
}
Ok(Value::Date(result))
} else if rhs.unit_equal_to("week", int)? {
Expand All @@ -228,6 +231,7 @@ impl Date {
for _ in 0..7 {
result = result.prev();
}
test_int(int)?;
}
Ok(Value::Date(result))
} else if rhs.unit_equal_to("month", int)? {
Expand Down
Loading