fix rounding of integers with sf - #389
Open
Joshix-1 wants to merge 13 commits into
Open
Conversation
Contributor
|
Author
|
what would be the expected behaviour for the first? |
Contributor
|
yes, I made PR which does that |
Joshix-1
force-pushed
the
fix-sf-rounding
branch
from
July 19, 2026 10:51
a2d3b1a to
3c07135
Compare
Author
|
Fixed it myself. |
Joshix-1
marked this pull request as draft
July 19, 2026 18:12
Joshix-1
marked this pull request as ready for review
July 19, 2026 19:33
Joshix-1
force-pushed
the
fix-sf-rounding
branch
from
July 20, 2026 16:58
fa37cb6 to
c46b72e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix #308 for big integers
Checklist