Skip to content

[Brand Refactor] PricingOptions fixes - #1377

Draft
danielguillan wants to merge 6 commits into
mainfrom
danielguillan/brand-refactor-qa-pricing-options-fixes
Draft

[Brand Refactor] PricingOptions fixes#1377
danielguillan wants to merge 6 commits into
mainfrom
danielguillan/brand-refactor-qa-pricing-options-fixes

Conversation

@danielguillan

Copy link
Copy Markdown
Collaborator

Summary

List of notable changes:

What should reviewers focus on?

Steps to test:

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • UI Changes contain new visual snapshots (generated by adding update snapshots label to the PR)
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fb00a98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@primer/react-brand Minor
@primer/brand-docs Minor
@primer/brand-css Minor
@primer/brand-primitives Minor
@primer/brand-e2e Minor
@primer/brand-fonts Minor
@primer/brand-config Minor
@primer/brand-storybook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@danielguillan
danielguillan force-pushed the danielguillan/brand-refactor-qa-pricing-options-fixes branch from e765810 to fb00a98 Compare June 16, 2026 13:40
@github-actions

Copy link
Copy Markdown
Contributor

🟢 No design token changes found

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Bundle size report

CheckMainBranchChange
UMD — full bundle (JS)99.28 kB99.20 kB✅ -84 B (-0.1%)
UMD — full bundle (CSS)65.25 kB65.38 kB⬆️ +143 B (+0.2%)
ESM — full bundle (JS + CSS)1.49 MB1.49 MB⬆️ +316 B (+0.0%)
ESM — tree-shaken simple (Button)68.19 kB68.25 kB⬆️ +66 B (+0.1%)
ESM — tree-shaken complex (ActionMenu)76.97 kB77.03 kB⬆️ +66 B (+0.1%)

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Unit test coverage changes found

Unit test coverage has been updated through this PR.

Changes: 0 new tests, 0 removed tests, 0 improved, 1 decreased

Component/Hook Statements Functions Branches Change
PricingOptions 99.2% 97.1% 97.0% 93.7% 93.1% -0.6%

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update to replace the previous fixtures.

Review visual differences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant