fix(agor-ui): make board sessions panel list scrollable#1814
Open
fitzee wants to merge 1 commit into
Open
Conversation
The session list in the sessions drawer/panel (BoardSessionList) sat in a plain block div with no bounded height or overflow, inside a wrapper that used overflow:hidden and an absolutely-positioned footer. Since the wrapper's height was pinned to 100% of its container, overflowing rows were clipped by overflow:hidden instead of becoming scrollable, so only ~10 of e.g. 33 sessions were reachable in a short viewport. Switch the wrapper to a flex column (search bar and footer flex-shrink:0, list flex:1 with overflowY:auto), matching the pattern already used in CommentsPanel. The footer no longer needs absolute positioning since flexbox naturally pins it to the bottom without overlapping the list. Fixes #1813
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BranchListDrawer.tsx/BoardSessionList) clipped its list instead of scrolling — header/footer showed the correct total (e.g. "33 sessions") but only ~10 rows were visible and unreachable, worse on short (non-fullscreen) viewports.flexShrink: 0, the session list isflex: 1; overflowY: auto. The footer no longer needsposition: absolutesince flexbox naturally pins it to the bottom without overlapping the list.Root cause
The list lived in a plain block
<div>with no bounded height/overflow, inside a wrapper that washeight: 100%; overflow: hiddenwith an absolutely-positioned footer. Because the wrapper's height was pinned to its container, any overflowing rows were clipped byoverflow: hiddenrather than becoming scrollable — there was no scroll container anywhere in the tree. This affected both usage sites: theBranchListDrawerand the "All sessions" tab inBoardAssistantPanel.Before / after
CommentsPanel), every row up to the header/footer count is reachable, and the footer stays pinned without covering the last rows. Verified full-screen and with few sessions still render cleanly with no awkward gaps.Test plan
BranchListDrawer.test.tsxpassesBoardAssistantPaneltests passFixes #1813