Skip to content

Fix zone config modal crash#1761

Merged
mistercrunch merged 1 commit into
mainfrom
fix-issue-1759
Jul 6, 2026
Merged

Fix zone config modal crash#1761
mistercrunch merged 1 commit into
mainfrom
fix-issue-1759

Conversation

@mistercrunch

@mistercrunch mistercrunch commented Jul 1, 2026

Copy link
Copy Markdown
Member

Fixes #1759.

Summary

  • Avoid rendering zone config/delete modals for every zone unless opened.
  • Stabilize the zone data passed into the config modal and narrow form initialization dependencies.
  • Derive zone node data typing from the canonical BoardObject union to reduce drift.
  • Add regression coverage for opening the zone config modal, preserving edits across parent rerenders, and keeping the modal component unmounted until opened.

Checks

  • pnpm i
  • ⚠️ pnpm check — earlier run passed typecheck, Biome lint, and short-id checks; failed at check:multitenancy-boundaries due unrelated pre-existing baseline violations in daemon files.
  • pnpm --filter agor-ui test -- src/components/SessionCanvas/canvas/BoardObjectNodes.test.tsx src/components/SessionCanvas/canvas/ZoneConfigModal.test.tsx
  • pnpm --filter @agor-live/client build (needed after rebasing onto main so generated client types include newer board fields)
  • pnpm --filter agor-ui typecheck
  • pnpm exec biome check apps/agor-ui/src/components/SessionCanvas/canvas/BoardObjectNodes.tsx apps/agor-ui/src/components/SessionCanvas/canvas/ZoneConfigModal.tsx apps/agor-ui/src/components/SessionCanvas/canvas/BoardObjectNodes.test.tsx apps/agor-ui/src/components/SessionCanvas/canvas/ZoneConfigModal.test.tsx

Notes

  • Rebasing onto current main resolved the merge conflicts by preserving the newer zone z-order/font-size work and layering this modal-mount fix on top.
  • AI follow-up review passed; PR is labeled ai-reviewed-gpt-5-5.

@mistercrunch mistercrunch added the ai-reviewed-gpt-5-5 Reviewed by GPT-5.5 AI reviewer label Jul 6, 2026
@mistercrunch mistercrunch merged commit fe0dee0 into main Jul 6, 2026
2 checks passed
@mistercrunch mistercrunch deleted the fix-issue-1759 branch July 6, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-reviewed-gpt-5-5 Reviewed by GPT-5.5 AI reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI crash: unknown component — Minified React error #185; visit https://react.dev/errors/185 for the full messa

1 participant