Fix zone config modal crash#1761
Merged
Merged
Conversation
ec5e674 to
d9da122
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1759.
Summary
BoardObjectunion to reduce drift.Checks
pnpm ipnpm check— earlier run passed typecheck, Biome lint, and short-id checks; failed atcheck:multitenancy-boundariesdue unrelated pre-existing baseline violations in daemon files.pnpm --filter agor-ui test -- src/components/SessionCanvas/canvas/BoardObjectNodes.test.tsx src/components/SessionCanvas/canvas/ZoneConfigModal.test.tsxpnpm --filter @agor-live/client build(needed after rebasing onto main so generated client types include newer board fields)pnpm --filter agor-ui typecheckpnpm exec biome check apps/agor-ui/src/components/SessionCanvas/canvas/BoardObjectNodes.tsx apps/agor-ui/src/components/SessionCanvas/canvas/ZoneConfigModal.tsx apps/agor-ui/src/components/SessionCanvas/canvas/BoardObjectNodes.test.tsx apps/agor-ui/src/components/SessionCanvas/canvas/ZoneConfigModal.test.tsxNotes
mainresolved the merge conflicts by preserving the newer zone z-order/font-size work and layering this modal-mount fix on top.ai-reviewed-gpt-5-5.