Add solid-mfem to flow-over-heated-plate - #928
Conversation
|
@j-signorelli nice to see this draft! Hint on the failing CI: we use pre-commit and this also checks and adjusts the formatting of some files. After you install it, do We can clearly improve the contributing guidelines here (tricky among multiple repositories). Any feedback is welcome. |
|
@MakisH gotcha, thank you! |
solid-mfem to flow-over-heated-platesolid-mfem to flow-over-heated-plate
|
@MakisH This is all ready for review! I don't think there are any required additions to make to the website based on what I saw - please let me know if I am mistaken. Also, I am not sure if I should put anything for |
|
@j-signorelli with a quick look, this PR already looks very clean, thank you! I will have a deeper look this week and integrate it to the system tests. |
MakisH
left a comment
There was a problem hiding this comment.
I could run the new case in the system tests, and the results look as expected:
The structure looks good, and the solid.cpp file looks clean (I did not look into details). The README.md mentions the new case.
The case is not configurable (parameters are hard-coded in solid.cpp), but so are also the cases in solid-nutils and solid-dunefem.
Note: In the Dockerfile, I modified the aste stage as well. I have checked that this works.
Thanks a lot once more for this PR! I will take care of the reference results and the integration to the website.
|
There are indeed quite a few command-line options. I meant having an adapter configuration file, similar to https://github.com/precice/tutorials/blob/develop/flow-over-heated-plate/solid-fenics/precice-adapter-config.json We now have an adapter configuration schema, which is still under development and evaluation: https://github.com/precice/adapter-schema In the future, we want to make all adapters (including such solvers provided in tutorials) conform to that schema. But that will still take a while. P.S.: The tutorial is now also on the website https://precice.org/tutorials-flow-over-heated-plate.html |

This PR adds an MFEM implementation of preCICE for the flow-over-heated-plate tutorial.
Checklist
changelog-entries/<PRnumber>.md.requirements.txtfiles, I regenerated siblingrequirements-reference.txtfiles withpython3 .dev-tools/releasing/update-requirements-reference.py(pass a path to update only that directory, or--allto refresh everything).For new tutorials or tutorial cases:
README.mdmetadata.yamltests/tests.yaml_config.yaml