Skip to content

Adkernel Bid Adapter: DSA support - #15387

Open
ckbo3hrk wants to merge 1 commit into
prebid:masterfrom
ckbo3hrk:adkernel_dsa
Open

Adkernel Bid Adapter: DSA support#15387
ckbo3hrk wants to merge 1 commit into
prebid:masterfrom
ckbo3hrk:adkernel_dsa

Conversation

@ckbo3hrk

@ckbo3hrk ckbo3hrk commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Type of change

  • Updated bidder adapter

Description of change

Added DSA support

Other information

prebid/prebid.github.io#6677

@github-actions

Copy link
Copy Markdown

This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named <bidderCode>BidAdapter, userId <userIdCode>IdSystem, RTD <rtdCode>RtdProvider, and analytics <analyticsCode>AnalyticsAdapter.

@github-actions

Copy link
Copy Markdown

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

  • Changes to modules/adkernelBidAdapter.js may need:
    • es.iterator.every
    • es.iterator.for-each
    • esnext.iterator.every
    • esnext.iterator.for-each
  • Changes to test/spec/modules/adkernelBidAdapter_spec.js may need:
    • es.array.with
    • esnext.array.with

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84ad2827f1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread modules/adkernelBidAdapter.js
@barecheck

barecheck Bot commented Jul 24, 2026

Copy link
Copy Markdown

Barecheck - Code coverage report

Total: 96.55%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
modules/adkernelBidAdapter.js340-342, 350-351, 439, 507, 510, 585, 609, 639, 648-649, 651-652, 654-655, 657
test/spec/modules/adkernelBidAdapter_spec.js804

@patmmccann

Copy link
Copy Markdown
Collaborator

hi does adkernal still have a relationship with hyperbrainz? see #15137

@ckbo3hrk

Copy link
Copy Markdown
Contributor Author

hi does adkernal still have a relationship with hyperbrainz? see #15137

@patmmccann They have a configured network, but there has been no traffic on it for a long time. I'll ask them in the referenced ticket about alias conflict.

@patmmccann

Copy link
Copy Markdown
Collaborator

@ckbo3hrk thank you; can you resolve conflict here

@patmmccann patmmccann self-assigned this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants