Synapse HX Bid Adapter : initial release by prebid-compas · Pull Request #15331 · prebid/Prebid.js

prebid-compas · 2026-07-09T07:57:17Z

Type of change

New bidder adapter

Description of change

New bidder adapter for Synapse HX
Maintainer: prebid@compas-inc.com

Other information

Docs PR - prebid/prebid.github.io#6657

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e8a3686751

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions · 2026-07-09T16:31:45Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/startioBidAdapter.js has 21 duplicated lines with modules/synapseHxBidAdapter.js
modules/startioBidAdapter.js has 31 duplicated lines with modules/synapseHxBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2026-07-09T16:38:20Z

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

modules/synapseHxBidAdapter.js

github-actions · 2026-07-09T16:39:18Z

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

Changes to modules/synapseHxBidAdapter.js may need:
- es.array.push
- es.iterator.constructor
- es.iterator.for-each
- esnext.iterator.constructor
- esnext.iterator.for-each
- web.url-search-params.delete
- web.url-search-params.has
- web.url-search-params.size
Changes to test/spec/modules/synapseHxBidAdapter_spec.js may need:
- es.iterator.constructor
- es.iterator.for-each
- es.json.stringify
- esnext.iterator.constructor
- esnext.iterator.for-each

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

barecheck · 2026-07-09T17:01:47Z

Barecheck - Code coverage report

Total: 96.67%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

github-actions · 2026-07-27T16:56:01Z

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

modules/startioBidAdapter.js has 21 duplicated lines with modules/synapseHxBidAdapter.js
modules/startioBidAdapter.js has 21 duplicated lines with modules/synapseHxBidAdapter.js

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

github-actions · 2026-07-27T16:56:49Z

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

Changes to modules/synapsehxBidAdapter.ts may need:
- es.array.push
- es.iterator.constructor
- es.iterator.for-each
- esnext.iterator.constructor
- esnext.iterator.for-each
- web.url-search-params.delete
- web.url-search-params.has
- web.url-search-params.size
Changes to test/spec/modules/synapsehxBidAdapter_spec.js may need:
- es.iterator.constructor
- es.iterator.for-each
- es.json.stringify
- esnext.iterator.constructor
- esnext.iterator.for-each

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

github-actions · 2026-07-27T16:56:55Z

This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named <bidderCode>BidAdapter, userId <userIdCode>IdSystem, RTD <rtdCode>RtdProvider, and analytics <analyticsCode>AnalyticsAdapter.

github-actions · 2026-07-27T16:57:49Z

Whoa there partner! This project is migrating to typescript. Consider changing the new JS files to TS, with well-defined types for what interacts with the prebid public API (for example: bid params and configuration). Thanks!

modules/synapsehxBidAdapter.js

patmmccann · 2026-08-05T02:41:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 935f135f3f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-05T02:50:25Z

+    if (bid.nurl) {
+      const url = new URL(bid.nurl);
+      url.searchParams.set('cpm', String(bid.cpm));
+      triggerPixel(url.toString());


Preserve win notice URLs before onBidWon

When Synapse returns a normal ORTB nurl (the fixture does this), converter.fromORTB does not leave that field on the Prebid bid; the default banner/video processors consume it into render assets instead. As a result this onBidWon branch never sees bid.nurl for bids produced by this adapter, so the intended win notice with the CPM is not sent on bid win. Preserve bid.nurl in the converter's bidResponse customizer (and avoid also consuming it there if necessary) before relying on this handler.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-05T02:50:25Z

+function makeUrl(bidRequests) {
+  return `${ENDPOINT_URL}?${formatQS({ pid: bidRequests[0].params.tenantId })}`;


Split batched requests by tenant

When a page has multiple Synapse HX bids with different tenantId values, bidderFactory passes them together to buildRequests, but this URL is built only from bidRequests[0] and the ORTB impressions do not carry the other tenants. Those later impressions are therefore sent under the first tenant's pid, causing misattribution or rejection for multi-tenant pages; split requests by tenantId or enforce a single tenant per request.

Useful? React with 👍 / 👎.

Implementation of the Synapse HX adapter

e8a3686

chatgpt-codex-connector Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread modules/synapseHxBidAdapter.js Outdated

Comment thread modules/synapseHxBidAdapter.js Outdated

prebid-compas mentioned this pull request Jul 9, 2026

Synapse HX Bid Adapter: Prebid.js support update prebid/prebid.github.io#6657

Open

7 tasks

github-advanced-security AI found potential problems Jul 9, 2026

View reviewed changes

Comment thread modules/synapseHxBidAdapter.js Fixed

review-assignment-bot Bot requested a review from jefftmahoney July 9, 2026 16:35

prebid-compas added 2 commits July 27, 2026 03:02

Adjustments according to review

c4cb58f

Merge branch 'master' into implement-synapse-hx-adapter

c74bf96

prebid-compas added 4 commits July 30, 2026 12:08

Adjustments according to review # 2

5fddad7

Merge branch 'master' into implement-synapse-hx-adapter

02915df

Merge branch 'master' into implement-synapse-hx-adapter

7f52687

Merge branch 'master' into implement-synapse-hx-adapter

03601a4

patmmccann reviewed Jul 31, 2026

View reviewed changes

Comment thread modules/synapsehxBidAdapter.md

prebid-compas added 2 commits August 4, 2026 18:36

Merge branch 'master' into implement-synapse-hx-adapter

1ea3ace

Migrate to TypeScript

935f135

chatgpt-codex-connector Bot reviewed Aug 5, 2026

View reviewed changes

		function makeUrl(bidRequests) {
		return `${ENDPOINT_URL}?${formatQS({ pid: bidRequests[0].params.tenantId })}`;

Uh oh!

Conversation

prebid-compas commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description of change

Other information

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

barecheck Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Barecheck - Code coverage report

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

github-actions Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 27, 2026

Uh oh!

github-actions Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

patmmccann commented Aug 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

prebid-compas commented Jul 9, 2026 •

edited

Loading

barecheck Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 27, 2026 •

edited

Loading

github-actions Bot commented Jul 27, 2026 •

edited

Loading