Skip to content

AdSmartx Adapter : Rebranded to Agenticx & Added support for audio ads - #15296

Merged
patmmccann merged 33 commits into
prebid:masterfrom
smart-exchange-ai-digital:master
Aug 3, 2026
Merged

AdSmartx Adapter : Rebranded to Agenticx & Added support for audio ads#15296
patmmccann merged 33 commits into
prebid:masterfrom
smart-exchange-ai-digital:master

Conversation

@pritishmd-talentica

@pritishmd-talentica pritishmd-talentica commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • [x ] Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Other information

Documentation PR
prebid/prebid.github.io#6649

pritishmd-talentica and others added 25 commits January 13, 2026 18:28
Update Master Branch From Upstream Master
…s-adapter-smart-exchange

Rm 1476 prebid js adapter smart exchange
…s-adapter-smart-exchange

RM-1476 : Handled prebid js PR review comments
…s-adapter-smart-exchange

RM-1476 : Commented that risemediatech adapter is deprecated
…s-adapter-smart-exchange

RM-1476 : Updated unit tests
…ing-Prebid-Adapter

RM-1891 : Rebranded AdSmartX Prebid adapter to AgenticX
Copilot AI review requested due to automatic review settings July 2, 2026 06:00
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/agenticxBidAdapter.js (+1 error)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR rebrands the AdSmartX bidder adapter to AgenticX and extends the adapter’s OpenRTB handling to include audio media types.

Changes:

  • Rebrand adapter code/endpoints from adsmartx to agenticx and switch to theagenticx.ai request/sync hosts.
  • Add AUDIO support in the shared ORTB converter/validator/response interpreter utilities.
  • Add/update adapter documentation and add a new unit test spec file (currently still referencing the old branding/URLs and needs alignment).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
test/spec/modules/agenticxBidAdapter_spec.js Adds adapter tests, but currently imports/targets adsmartx and the old endpoints/sync domains.
modules/agenticxBidAdapter.md Updates documentation to AgenticX branding and mentions Audio support.
modules/agenticxBidAdapter.js Updates bidder code + endpoints and expands supportedMediaTypes to include AUDIO.
libraries/agenticxUtils/bidderUtils.js Adds AUDIO handling in impression building, request validation, and response interpretation.
Comments suppressed due to low confidence (3)

modules/agenticxBidAdapter.js:34

  • The TODO comment still references "AdSmartX" after the rebrand to AgenticX, which makes the adapter history confusing for maintainers.
    libraries/agenticxUtils/bidderUtils.js:60
  • The else if chain means imp.audio is only populated when neither banner nor video are present. With multi-format requests (e.g. banner+audio or video+audio), audio will be dropped even though supportedMediaTypes includes AUDIO.
    libraries/agenticxUtils/bidderUtils.js:221
  • Audio support is added here (mtype=3 -> mediaType = AUDIO), but there are no unit tests covering audio request validation (mediaTypes.audio.mimes) or audio bid interpretation (mtype=3). This makes regressions likely and may leave the change below the repo’s expected unit-test coverage for modified code.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

import { spec } from 'modules/adsmartxBidAdapter.js';

P2 Badge Point the renamed spec at AgenticX

The renamed agenticxBidAdapter_spec.js still imports the deleted modules/adsmartxBidAdapter.js, so the affected unit test file fails to load and never exercises the new adapter; it also leaves the old AdSmartX bidder/endpoint expectations in the same spec. Update the import and fixtures to the AgenticX module/URLs so the new behavior is covered.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread modules/agenticxBidAdapter.js
Comment thread libraries/agenticxUtils/bidderUtils.js
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/agenticxBidAdapter.js (+1 error)

@pritishmd-talentica

Copy link
Copy Markdown
Contributor Author

Hi , Can we please have a review of this PR?

@github-actions

Copy link
Copy Markdown

This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:

  • Changes to libraries/agenticxUtils/bidderUtils.js may need:
    • es.array.push
    • es.iterator.constructor
    • es.iterator.find
    • es.iterator.for-each
    • es.iterator.map
    • es.iterator.some
    • esnext.iterator.constructor
    • esnext.iterator.find
    • esnext.iterator.for-each
    • esnext.iterator.map
    • esnext.iterator.some
  • Changes to test/spec/modules/agenticxBidAdapter_spec.js may need:
    • es.array.with
    • esnext.array.with

The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers.

@pritishmd-talentica

Copy link
Copy Markdown
Contributor Author

@gwhigs @jlquaccia Can you please review the PR?

Copilot AI review requested due to automatic review settings July 23, 2026 05:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

modules/agenticxBidAdapter.js:9

  • The shared bidder utils appear to have been renamed/moved from libraries/adsmartxUtils/bidderUtils.js to libraries/agenticxUtils/bidderUtils.js, but there is still a unit test importing the old path (test/spec/libraries/adsmartxUtils/bidderUtils_spec.js:9). In the current tree, libraries/adsmartxUtils/bidderUtils.js does not exist, so that spec will fail to load and break the test run. Update the spec to import from the new agenticxUtils location (and rename the describe text if desired), or add a compatibility re-export at the old path if you need to keep it.

Copilot AI review requested due to automatic review settings July 23, 2026 06:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

modules/agenticxBidAdapter.js:36

  • spec.code was changed from adsmartx to agenticx, which is a breaking change for existing publisher configs. Consider adding an aliases: ['adsmartx'] entry to preserve backwards compatibility. Also the TODO still references "AdSmartX"; it should be updated to match the new branding.
    libraries/agenticxUtils/bidderUtils.js:61
  • The new audio impression logic merges the raw mediaTypes.audio object into imp.audio. Prebid's mediaTypes.audio can include non-OpenRTB keys (e.g. context, renderer, useCacheKey), so copying it wholesale can generate invalid OpenRTB requests. Strip known PBJS-only keys before merging into imp.audio (or otherwise filter to OpenRTB fields).
    libraries/agenticxUtils/bidderUtils.js:3
  • There is still a unit test importing the old libraries/adsmartxUtils/bidderUtils.js path (test/spec/libraries/adsmartxUtils/bidderUtils_spec.js:9), but libraries/adsmartxUtils/ no longer exists. This will cause the test suite to fail with a module-not-found error unless that test (and any remaining references) is updated/renamed to agenticxUtils or removed along with the old adapter rename.

pritishmd-talentica and others added 2 commits July 23, 2026 11:52
…ing-Prebid-Adapter

RM-1891: Add unit tests for AgenticX bidderUtils with support for audio
Copilot AI review requested due to automatic review settings July 30, 2026 10:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

libraries/agenticxUtils/bidderUtils.js:60

  • The impression builder uses an if / else if chain for banner/video/audio, so only one media type is ever included in the ORTB imp. If an ad unit is configured with multiple mediaTypes (e.g. banner + audio), the later types are silently dropped even though supportedMediaTypes includes them. If multi-format support is intended, consider allowing multiple imp.* objects (or otherwise documenting/encoding the selection logic).
    modules/agenticxBidAdapter.js:34
  • This TODO still references the old AdSmartX name after the rebrand; please update it to avoid confusion when following up on the missing gvlid.

@pritishmd-talentica

Copy link
Copy Markdown
Contributor Author

Hi, Can we have a code review of this PR

@pritishmd-talentica

Copy link
Copy Markdown
Contributor Author

Hi @gwhigs & @jlquaccia , Please review the PR

@patmmccann

Copy link
Copy Markdown
Collaborator

approving only bc you have zero users; this is breaking if there were users

@patmmccann
patmmccann merged commit 17ece01 into prebid:master Aug 3, 2026
113 of 114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants