AdSmartx Adapter : Rebranded to Agenticx & Added support for audio ads - #15296
Conversation
Update Master Branch From Upstream Master
…s-adapter-smart-exchange Rm 1476 prebid js adapter smart exchange
…-adapter-smart-exchange
…s-adapter-smart-exchange RM-1476 : Handled prebid js PR review comments
Update forked master
…bid adapter is deprecated
…s-adapter-smart-exchange RM-1476 : Commented that risemediatech adapter is deprecated
…s-adapter-smart-exchange RM-1476 : Updated unit tests
Update master of fork
…ing-Prebid-Adapter RM-1891 : Rebranded AdSmartX Prebid adapter to AgenticX
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
There was a problem hiding this comment.
Pull request overview
This PR rebrands the AdSmartX bidder adapter to AgenticX and extends the adapter’s OpenRTB handling to include audio media types.
Changes:
- Rebrand adapter code/endpoints from
adsmartxtoagenticxand switch totheagenticx.airequest/sync hosts. - Add AUDIO support in the shared ORTB converter/validator/response interpreter utilities.
- Add/update adapter documentation and add a new unit test spec file (currently still referencing the old branding/URLs and needs alignment).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/spec/modules/agenticxBidAdapter_spec.js |
Adds adapter tests, but currently imports/targets adsmartx and the old endpoints/sync domains. |
modules/agenticxBidAdapter.md |
Updates documentation to AgenticX branding and mentions Audio support. |
modules/agenticxBidAdapter.js |
Updates bidder code + endpoints and expands supportedMediaTypes to include AUDIO. |
libraries/agenticxUtils/bidderUtils.js |
Adds AUDIO handling in impression building, request validation, and response interpretation. |
Comments suppressed due to low confidence (3)
modules/agenticxBidAdapter.js:34
- The TODO comment still references "AdSmartX" after the rebrand to AgenticX, which makes the adapter history confusing for maintainers.
libraries/agenticxUtils/bidderUtils.js:60 - The
else ifchain meansimp.audiois only populated when neither banner nor video are present. With multi-format requests (e.g. banner+audio or video+audio), audio will be dropped even thoughsupportedMediaTypesincludes AUDIO.
libraries/agenticxUtils/bidderUtils.js:221 - Audio support is added here (mtype=3 ->
mediaType = AUDIO), but there are no unit tests covering audio request validation (mediaTypes.audio.mimes) or audio bid interpretation (mtype=3). This makes regressions likely and may leave the change below the repo’s expected unit-test coverage for modified code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
The renamed agenticxBidAdapter_spec.js still imports the deleted modules/adsmartxBidAdapter.js, so the affected unit test file fails to load and never exercises the new adapter; it also leaves the old AdSmartX bidder/endpoint expectations in the same spec. Update the import and fixtures to the AgenticX module/URLs so the new behavior is covered.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
|
Hi , Can we please have a review of this PR? |
…ing-Prebid-Adapter RM-1891 : Fixed linter issues
|
This PR introduces changes that may not work on all browsers. According to Babel, the following polyfills may be needed, and they are not automatically included:
The best way to address this is to provide good test coverage, as normal PR checks run unit tests on older browsers. |
|
@gwhigs @jlquaccia Can you please review the PR? |
…ing-Prebid-Adapter RM-1891: Updated tests
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
modules/agenticxBidAdapter.js:9
- The shared bidder utils appear to have been renamed/moved from
libraries/adsmartxUtils/bidderUtils.jstolibraries/agenticxUtils/bidderUtils.js, but there is still a unit test importing the old path (test/spec/libraries/adsmartxUtils/bidderUtils_spec.js:9). In the current tree,libraries/adsmartxUtils/bidderUtils.jsdoes not exist, so that spec will fail to load and break the test run. Update the spec to import from the newagenticxUtilslocation (and rename the describe text if desired), or add a compatibility re-export at the old path if you need to keep it.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
modules/agenticxBidAdapter.js:36
spec.codewas changed fromadsmartxtoagenticx, which is a breaking change for existing publisher configs. Consider adding analiases: ['adsmartx']entry to preserve backwards compatibility. Also the TODO still references "AdSmartX"; it should be updated to match the new branding.
libraries/agenticxUtils/bidderUtils.js:61- The new audio impression logic merges the raw
mediaTypes.audioobject intoimp.audio. Prebid'smediaTypes.audiocan include non-OpenRTB keys (e.g.context,renderer,useCacheKey), so copying it wholesale can generate invalid OpenRTB requests. Strip known PBJS-only keys before merging intoimp.audio(or otherwise filter to OpenRTB fields).
libraries/agenticxUtils/bidderUtils.js:3 - There is still a unit test importing the old
libraries/adsmartxUtils/bidderUtils.jspath (test/spec/libraries/adsmartxUtils/bidderUtils_spec.js:9), butlibraries/adsmartxUtils/no longer exists. This will cause the test suite to fail with a module-not-found error unless that test (and any remaining references) is updated/renamed toagenticxUtilsor removed along with the old adapter rename.
…ing-Prebid-Adapter RM-1891: Add unit tests for AgenticX bidderUtils with support for audio
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
libraries/agenticxUtils/bidderUtils.js:60
- The impression builder uses an
if / else ifchain for banner/video/audio, so only one media type is ever included in the ORTBimp. If an ad unit is configured with multiple mediaTypes (e.g. banner + audio), the later types are silently dropped even thoughsupportedMediaTypesincludes them. If multi-format support is intended, consider allowing multipleimp.*objects (or otherwise documenting/encoding the selection logic).
modules/agenticxBidAdapter.js:34 - This TODO still references the old AdSmartX name after the rebrand; please update it to avoid confusion when following up on the missing gvlid.
|
Hi, Can we have a code review of this PR |
|
Hi @gwhigs & @jlquaccia , Please review the PR |
|
approving only bc you have zero users; this is breaking if there were users |
Type of change
Bugfix
Feature
New bidder adapter
[x ] Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information
Documentation PR
prebid/prebid.github.io#6649