Appnerve Bid Adapter - #15254
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbf461d95b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const imp: any = { | ||
| id: bid.bidId, | ||
| tagid: sourceId(bid), | ||
| secure: 1, | ||
| ext: {tid: bid.transactionId, prebid: {storedrequest: {id: sourceId(bid)}}} |
There was a problem hiding this comment.
For ad units with ortb2Imp values such as GPID/adserver data, instl, or publisher/prebid ext.tid, this builds a fresh OpenRTB impression and writes ext.tid from the legacy bid.transactionId, so those impression fields are dropped or overridden before the request is sent. Prebid carries the authoritative impression TID on bid.ortb2Imp.ext.tid, including publisher-supplied TIDs, so Appnerve can receive the wrong TID and miss GPID/FPD in those auctions; merge bid.ortb2Imp into imp and layer adapter-specific ext fields on top.
Useful? React with 👍 / 👎.
| delete video.playerSize; | ||
| imp.video = video; | ||
| } | ||
| if (bid.mediaTypes?.native) imp.native = {request: JSON.stringify(nativeRequest(bid.mediaTypes.native)), ver: '1.2'}; |
There was a problem hiding this comment.
When a publisher configures native with mediaTypes.native.ortb (or the nativeOrtbRequest derived by Prebid), this passes the wrapper object into nativeRequest(), which only reads legacy keys like title and image; ORTB-only native requests therefore serialize with an empty assets array and lose the required native asset definitions. Use bid.nativeOrtbRequest/bid.mediaTypes.native.ortb directly, or convert ORTB requests before building the impression.
Useful? React with 👍 / 👎.
|
Tread carefully! This PR adds 279 linter errors (possibly disabled through directives):
|
|
This PR includes an adapter whose code does not match its file name. Bid adapter modules should be named |
|
Tread carefully! This PR adds 279 linter errors (possibly disabled through directives):
|
2 participants
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Adds the Appnerve bid adapter for Prebid.js.
Maintainer contact:
// Banner
{
bidder: 'appnerve',
params: {
sourceId: '74000976'
}
}
// Video
{
bidder: 'appnerve',
params: {
sourceId: '76669556'
}
}
// Native
{
bidder: 'appnerve',
params: {
sourceId: '58684344'
}
}
Supported media types: banner(300x250), video, native(128x128 icon, 1200x627), audio
Related documentation PR: prebid/prebid.github.io#6645
Tests run:
gulp build --modules=appnerveBidAdapter
gulp test --file "test/spec/modules/appnerveBidAdapter_spec.js"
gulp lint --file "modules/appnerveBidAdapter.ts"
Adds:
modules/appnerveBidAdapter.ts
modules/appnerveBidAdapter.md
test/spec/modules/appnerveBidAdapter_spec.js
Related docs PR: prebid/prebid.github.io#6645