Support createPortal in core by JoviDeCroock · Pull Request #5168 · preactjs/preact

JoviDeCroock · 2026-07-18T05:59:51Z

This moves createPortal into core and adds support for a new primitive so we can support other libraries manipulating the roots. With _parentDom you can change up the root of the diff algorithm. As we already support _parentDom in mangle this will mangle to __P

Co-Authored with GPT5.6-sol for moving tests around and translating to class components

github-actions · 2026-07-18T06:00:11Z

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -1% - +0% (-4.60ms - +2.45ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -1% - +0% (-0.15ms - +0.06ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -1% - +3% (-0.30ms - +1.49ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -3% - +1% (-0.57ms - +0.10ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -2% - +0% (-0.80ms - +0.15ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -5% - +3% (-0.07ms - +0.03ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -2% - +1% (-0.62ms - +0.25ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -1% - +5% (-0.27ms - +1.29ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 +0% - +0% (+0.01ms - +0.01ms)
^{preact-local vs preact-main}
filter-list: slower ❌ 0% - 1% (0.01ms - 0.01ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -2% - +2% (-0.10ms - +0.12ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 +0% - +0% (+0.01ms - +0.01ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 +0% - +0% (+0.01ms - +0.01ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -2% - +4% (-0.02ms - +0.04ms)
^{preact-local vs preact-main}
todo: slower ❌ 1% - 1% (0.01ms - 0.01ms)
^{preact-local vs preact-main}
update10th1k: slower ❌ 0% - 1% (0.01ms - 0.02ms)
^{preact-local vs preact-main}

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: CI #5703
Commit: 9d54bad

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	832.46ms - 836.97ms	-	unsure 🔍 -1% - +0% -4.60ms - +2.45ms
preact-main	833.08ms - 838.50ms	unsure 🔍 -0% - +1% -2.45ms - +4.60ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.09ms - 19.09ms	-	unsure 🔍 +0% - +0% +0.01ms - +0.01ms
preact-main	19.08ms - 19.08ms	unsure 🔍 -0% - -0% -0.01ms - -0.01ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: CI #5703
Commit: 9d54bad

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.52ms - 16.62ms	-	unsure 🔍 -1% - +0% -0.15ms - +0.06ms
preact-main	16.52ms - 16.70ms	unsure 🔍 -0% - +1% -0.06ms - +0.15ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.56ms - 1.57ms	-	slower ❌ 0% - 1% 0.01ms - 0.01ms
preact-main	1.55ms - 1.56ms	faster ✔ 0% - 1% 0.01ms - 0.01ms	-

hydrate1k

Browser: chrome-headless
Sample size: 50
Built by: CI #5703
Commit: 9d54bad

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	56.28ms - 57.76ms	-	unsure 🔍 -1% - +3% -0.30ms - +1.49ms
preact-main	55.91ms - 56.93ms	unsure 🔍 -3% - +1% -1.49ms - +0.30ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.98ms - 5.13ms	-	unsure 🔍 -2% - +2% -0.10ms - +0.12ms
preact-main	4.97ms - 5.12ms	unsure 🔍 -2% - +2% -0.12ms - +0.10ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: CI #5703
Commit: 9d54bad

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.53ms - 16.57ms	-	unsure 🔍 -3% - +1% -0.57ms - +0.10ms
preact-main	16.46ms - 17.12ms	unsure 🔍 -1% - +3% -0.10ms - +0.57ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.75ms - 3.76ms	-	unsure 🔍 +0% - +0% +0.01ms - +0.01ms
preact-main	3.74ms - 3.74ms	unsure 🔍 -0% - -0% -0.01ms - -0.01ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: CI #5703
Commit: 9d54bad

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	49.75ms - 50.38ms	-	unsure 🔍 -2% - +0% -0.80ms - +0.15ms
preact-main	50.03ms - 50.75ms	unsure 🔍 -0% - +2% -0.15ms - +0.80ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.02ms - 3.03ms	-	unsure 🔍 +0% - +0% +0.01ms - +0.01ms
preact-main	3.01ms - 3.02ms	unsure 🔍 -0% - -0% -0.01ms - -0.01ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.12ms - 25.76ms	-	unsure 🔍 -1% - +2% -0.37ms - +0.55ms
preact-main	25.01ms - 25.69ms	unsure 🔍 -2% - +1% -0.55ms - +0.37ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	29.20ms - 30.22ms	-	unsure 🔍 -1% - +4% -0.28ms - +1.12ms
preact-main	28.81ms - 29.77ms	unsure 🔍 -4% - +1% -1.12ms - +0.28ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.58ms - 26.43ms	-	unsure 🔍 -0% - +4% -0.02ms - +1.13ms
preact-main	25.07ms - 25.84ms	unsure 🔍 -4% - +0% -1.13ms - +0.02ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.72ms - 23.02ms	-	unsure 🔍 -1% - +1% -0.16ms - +0.21ms
preact-main	22.74ms - 22.96ms	unsure 🔍 -1% - +1% -0.21ms - +0.16ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.04ms - 25.06ms	-	unsure 🔍 -2% - +4% -0.52ms - +0.91ms
preact-main	23.86ms - 24.86ms	unsure 🔍 -4% - +2% -0.91ms - +0.52ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	17.69ms - 17.99ms	-	unsure 🔍 -2% - +1% -0.31ms - +0.12ms
preact-main	17.78ms - 18.09ms	unsure 🔍 -1% - +2% -0.12ms - +0.31ms	-

text-update

Browser: chrome-headless
Sample size: 240
Built by: CI #5703
Commit: 9d54bad

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.29ms - 1.36ms	-	unsure 🔍 -5% - +3% -0.07ms - +0.03ms
preact-main	1.31ms - 1.38ms	unsure 🔍 -3% - +5% -0.03ms - +0.07ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.04ms - 1.09ms	-	unsure 🔍 -2% - +4% -0.02ms - +0.04ms
preact-main	1.04ms - 1.08ms	unsure 🔍 -3% - +2% -0.04ms - +0.02ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: CI #5703
Commit: 9d54bad

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.55ms - 33.95ms	-	unsure 🔍 -2% - +1% -0.62ms - +0.25ms
preact-main	33.55ms - 34.32ms	unsure 🔍 -1% - +2% -0.25ms - +0.62ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.28ms - 1.28ms	-	slower ❌ 1% - 1% 0.01ms - 0.01ms
preact-main	1.27ms - 1.27ms	faster ✔ 1% - 1% 0.01ms - 0.01ms	-

update10th1k

Browser: chrome-headless
Sample size: 140
Built by: CI #5703
Commit: 9d54bad

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.84ms - 27.96ms	-	unsure 🔍 -1% - +5% -0.27ms - +1.29ms
preact-main	26.35ms - 27.44ms	unsure 🔍 -5% - +1% -1.29ms - +0.27ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.99ms - 2.99ms	-	slower ❌ 0% - 1% 0.01ms - 0.02ms
preact-main	2.97ms - 2.98ms	faster ✔ 0% - 1% 0.01ms - 0.02ms	-

_{tachometer-reporter-action v2 for CI}

github-actions · 2026-07-18T06:00:47Z

Size Change: -92 B (-0.58%)

Total Size: 15.8 kB

📦 View Changed

Filename	Size	Change
`compat/dist/compat.mjs`	3.7 kB	-209 B (-5.34%)	✅
`dist/preact.mjs`	5.01 kB	+117 B (+2.39%)

ℹ️ View Unchanged

Filename	Size
`debug/dist/debug.mjs`	3.89 kB
`devtools/dist/devtools.mjs`	274 B
`hooks/dist/hooks.mjs`	1.55 kB
`jsx-runtime/dist/jsxRuntime.mjs`	861 B
`test-utils/dist/testUtils.mjs`	473 B

_{compressed-size-action}

coveralls · 2026-07-18T06:02:05Z

coverage: 98.492% (-0.05%) from 98.541% — JoviDeCroock/portal-parentdom-in-core into main

Support createPortal in core

ec0a288

rschristian approved these changes Jul 18, 2026

View reviewed changes

Merge branch 'main' into JoviDeCroock/portal-parentdom-in-core

9d54bad

JoviDeCroock merged commit 6254ee1 into main Jul 19, 2026
13 checks passed

JoviDeCroock deleted the JoviDeCroock/portal-parentdom-in-core branch July 19, 2026 04:15

Uh oh!

Uh oh!

Conversation

JoviDeCroock commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

Uh oh!

github-actions Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JoviDeCroock commented Jul 18, 2026 •

edited

Loading

github-actions Bot commented Jul 18, 2026 •

edited

Loading

github-actions Bot commented Jul 18, 2026 •

edited

Loading

coveralls commented Jul 18, 2026 •

edited

Loading