Allow execution of DemoFilesGenerator with mvn compile exec:exec#433
Open
NathanDissoubray wants to merge 2 commits into
Open
Allow execution of DemoFilesGenerator with mvn compile exec:exec#433NathanDissoubray wants to merge 2 commits into
DemoFilesGenerator with mvn compile exec:exec#433NathanDissoubray wants to merge 2 commits into
Conversation
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
Signed-off-by: NathanDissoubray <nathan.dissoubray@rte-france.com>
|
NathanDissoubray
changed the title
DemoFilesGenerator with mvn compile exec:exec
massimo-ferraro
approved these changes
Jul 22, 2026
massimo-ferraro
left a comment
massimo-ferraro
left a comment
Contributor
There was a problem hiding this comment.
It seems fine. But for running correctly this command, in this branch, you need to change the NadDemoFiles class, for removing trailing spaces, and saving the SLD diagrams in the correct folder. You already did these fixes in another PR, the one that updates the dependencies. Maybe it could be worth to say it in the PR description, that you require those fixes, and that PR, to actually be able to run the command and generate the demo files
Author
|
Right, I had assumed the other PR would be merged first but I indeed forgot to write it, thanks for the reminder |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
None
What kind of change does this PR introduce?
Feature, docs
What is the current behavior?
Cannot execute
DemoFilesGeneratoreasily.Working method is:
mvn compile dependency:copy-dependencies -DoutputDirectory=target/dependency java -cp "target/classes:target/dependency/*" com.powsybl.viewer.demo.DemoFilesGeneratorWhat is the new behavior (if this is a feature change)?
Can execute generator with
mvn compile exec:exec. Added doc in the readme.Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information:
Original working command from @massimo-ferraro, thanks for helping with finding a way to make it work.
Needs #426 to be merged first