Skip to content

[nad-viewer] Add SVG width and height in NAD creation from metadata#428

Open
massimo-ferraro wants to merge 2 commits into
integration/nad_create_svgfrom
nad_create_svg_width_height
Open

[nad-viewer] Add SVG width and height in NAD creation from metadata#428
massimo-ferraro wants to merge 2 commits into
integration/nad_create_svgfrom
nad_create_svg_width_height

Conversation

@massimo-ferraro

@massimo-ferraro massimo-ferraro commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
no

What kind of change does this PR introduce?
feature

What is the current behavior?
In the NAD viewer, the SVG writer that creates the SVG starting from diagram metadata does not add width and height to the SVG, even if the svgWidthAndHeightAdded metadata parameter is set to true

What is the new behavior (if this is a feature change)?
In the NAD viewer, the SVG writer that creates the SVG starting from diagram metadata, if the svgWidthAndHeightAdded metadata parameter is set to true, adds width and height to the SVG

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

The PR renamed the metadata utils getViewBox function to getViewBoxAndDimensions, changing the result type from ViewBox to Dimensions, i.e. including in the results also the size of the SVG, not only the viewbox. You can see the changes in the function test

Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
@massimo-ferraro massimo-ferraro self-assigned this Jul 14, 2026
@NathanDissoubray NathanDissoubray added the bug Something isn't working label Jul 20, 2026
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
@sonarqubecloud

Copy link
Copy Markdown

@NathanDissoubray NathanDissoubray added the Breaking change API is broken label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking change API is broken bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants