[nad-viewer] Add diagrams to test data for creation of SVG from metadata#421
Open
massimo-ferraro wants to merge 3 commits into
Open
[nad-viewer] Add diagrams to test data for creation of SVG from metadata#421massimo-ferraro wants to merge 3 commits into
massimo-ferraro wants to merge 3 commits into
Conversation
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
NathanDissoubray
requested changes
Jul 6, 2026
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
Signed-off-by: massimo.ferraro <massimo.ferraro@soft.it>
|
NathanDissoubray
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
tests update
What is the current behavior?
There are a couple of tests for the creation of NAD SVG from diagram metadata
What is the new behavior (if this is a feature change)?
There are more tests and test data for the creation of NAD SVG from diagram metadata
Does this PR introduce a breaking change or deprecate an API?