Skip to content

Fix compatibility with latest AirPlay - #2846

Open
jlacivita wants to merge 3 commits into
postlund:masterfrom
jlacivita:playurl-fixes
Open

Fix compatibility with latest AirPlay#2846
jlacivita wants to merge 3 commits into
postlund:masterfrom
jlacivita:playurl-fixes

Conversation

@jlacivita

@jlacivita jlacivita commented Apr 25, 2026

Copy link
Copy Markdown

Summary

  • Fixed play_url to work with the latest AirPlay protocol changes

Test plan

  • Manually tested play_url against AppleTV and Samsung Frame 2025

@robkochman

Copy link
Copy Markdown

I reworked this approach against current master and published the result at
robkochman:codex/play-url-tvos26,
commit 8144c77c.

The revised implementation keeps the modern /command queue flow while:

  • using stream-specific identifiers and headers;
  • driving playback completion from event-channel state transitions;
  • waiting for a real startup transition instead of treating the first state as success;
  • avoiding the unrelated dependency churn and raw protocol logging; and
  • adding regression coverage for the queue commands and playback state handling.

Validation completed:

  • full suite: 1255 passed, 6 skipped;
  • Black, isort, Flake8, mypy, and Pylint all pass;
  • live tvOS 26.5 tests: remote HLS, local HLS, and local progressive MP4 all reached
    playing; local media then reached stopped/ended normally; and
  • an H.264/AAC visual announcement with embedded audio completed successfully through
    an application wrapper.

I do not have permission to update this PR's source branch directly, so I am linking
the tested branch for the author or maintainers to compare or cherry-pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants