Skip to content

Fix: Do not mutate parameters when serializing in Bind - fixes multiple serialization on retry #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
porsager merged 2 commits into from
Sep 2, 2026
+82 −1
Merged

Fix: Do not mutate parameters when serializing in Bind - fixes multiple serialization on retry #1198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b6a148
Add tests for double serialization of parameters on prepared query retry
Ne7Le4DeR Aug 21, 2026
7f70f8c
Do not mutate parameters when serializing in Bind
Ne7Le4DeR Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,7 @@ function Connection(options, queues = {}, { onopen = noop, onend = noop, onclose
return b.i32(0xFFFFFFFF)

type = types[i]
parameters[i] = x = type in options.serializers
x = type in options.serializers
? options.serializers[type](x)
: '' + x

Expand Down
81 changes: 81 additions & 0 deletions tests/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1824,6 +1824,87 @@ t('Recreate prepared statements on RevalidateCachedQuery error', async() => {
]
})

t('Does not re-serialize json parameters when retrying on RevalidateCachedQuery error', async() => {
const update = () => sql`update test set config = ${ sql.json({ warmup: 2100000000, ticksLimit: 5000 }) } returning *`
await sql`create table test (id int, config jsonb)`
await sql`insert into test values (1, '{}')`
await update()
await sql`alter table test add column extra int`
await update()
return [
'object',
(await sql`select jsonb_typeof(config) as type from test`)[0].type,
await sql`drop table test`
]
})

t('Does not re-serialize json parameters when retrying on FetchPreparedStatement error', async() => {
const insert = () => sql`insert into test (config) values (${ sql.json({ warmup: 2100000000 }) })`
await sql`create table test (config jsonb)`
await insert()
await sql`deallocate all`
await insert()
return [
'object,object',
(await sql`select jsonb_typeof(config) as type from test`).map(x => x.type).join(),
await sql`drop table test`
]
})

t('Does not re-serialize boolean parameters when retrying on RevalidateCachedQuery error', async() => {
const update = () => sql`update test set enabled = ${ true } returning *`
await sql`create table test (id int, enabled bool)`
await sql`insert into test values (1, false)`
await update()
await sql`alter table test add column extra int`
await update()
return [
true,
(await sql`select enabled from test`)[0].enabled,
await sql`drop table test`
]
})

t('Does not re-serialize boolean parameters when retrying on FetchPreparedStatement error', async() => {
const insert = () => sql`insert into test (enabled) values (${ true })`
await sql`create table test (enabled bool)`
await insert()
await sql`deallocate all`
await insert()
return [
'true,true',
(await sql`select enabled from test`).map(x => x.enabled).join(),
await sql`drop table test`
]
})

t('Does not re-serialize bytea parameters when retrying on RevalidateCachedQuery error', async() => {
const update = () => sql`update test set data = ${ Buffer.from('hello') } returning *`
await sql`create table test (id int, data bytea)`
await sql`insert into test values (1, null)`
await update()
await sql`alter table test add column extra int`
await update()
return [
'hello',
(await sql`select data from test`)[0].data.toString(),
await sql`drop table test`
]
})

t('Does not re-serialize bytea parameters when retrying on FetchPreparedStatement error', async() => {
const insert = () => sql`insert into test (data) values (${ Buffer.from('hello') })`
await sql`create table test (data bytea)`
await insert()
await sql`deallocate all`
await insert()
return [
'hello,hello',
(await sql`select data from test`).map(x => x.data.toString()).join(),
await sql`drop table test`
]
})

t('Properly throws routine error on not prepared statements', async() => {
await sql`create table x (x text[])`
const { routine } = await sql.unsafe(`
Expand Down